Ben Konyi
8e00ebc689
google3 makes heavy use of symlinks, with no guarantee that the relative location of files with respect to each other will be maintained after the symlinks are resolved. This causes issues when trying to locate the DartDev snapshot using the VM executables resolved path as a base. This change updates the DartDev snapshot detection logic to first try to find the snapshot using the resolved executable path before falling back to using the unresolved path used to launch the VM (e.g., the path specified by argv[0]). TEST=pkg/dartdev/test/ Change-Id: I19a41c440ac82cbc671dafb3bda23a31fb4cdc0c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370000 Reviewed-by: Derek Xu <derekx@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency