Vyacheslav Egorov
c111f693c7
Freelist implementation was trying to mark pages executable (RX) which does not respect possibility that it is working with RW mapping which can't be directly marked as executable. It needed to use RO permission instead if dual mapping is enabled. This CL consolidates all code mentioning RX permission in one place: VirtualMemory::WriteProtectCode so that we avoid this mistake in the future. R=kustermann@google.com TEST=tested by doing large reloads which cause more churn in code space Change-Id: If99692cac3ce3ff54b907e4c43d7f26bae7439ff Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435860 Commit-Queue: Martin Kustermann <kustermann@google.com> Auto-Submit: Slava Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>