Vyacheslav Egorov
99a5f149ac
Relanding 4be50d6fa1 with fixes to DBC
and location summaries: AssertAssignable must save FPU registers.
For now we are limiting this to type checks against type parameter types.
In Dart 1 mode Dart2JS compiles itself in 28s when running from source
and in 23s when running from ideal app-jit snapshot (trained on the
same workload).
Before this change in Dart 2 mode numbers were 51s and 57s respectively.
After this change in Dart 2 mode numbers are 38s and 32s. Meaning
that regression is reduced by 50%.
Issue https://github.com/dart-lang/sdk/issues/31798
Issue https://github.com/dart-lang/sdk/issues/33257
Change-Id: Ifb55f86453bfdf36a2e03bcd7f3197cfde257103
Reviewed-on: https://dart-review.googlesource.com/57980
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
82 lines
2.7 KiB
C++
82 lines
2.7 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
|
|
#if defined(TARGET_ARCH_X64)
|
|
|
|
#include "vm/code_patcher.h"
|
|
#include "vm/instructions.h"
|
|
#include "vm/instructions_x64.h"
|
|
|
|
#include "vm/constants_x64.h"
|
|
#include "vm/cpu.h"
|
|
#include "vm/object.h"
|
|
|
|
namespace dart {
|
|
|
|
bool DecodeLoadObjectFromPoolOrThread(uword pc, const Code& code, Object* obj) {
|
|
ASSERT(code.ContainsInstructionAt(pc));
|
|
|
|
uint8_t* bytes = reinterpret_cast<uint8_t*>(pc);
|
|
|
|
COMPILE_ASSERT(PP == R15);
|
|
if ((bytes[0] == 0x49) || (bytes[0] == 0x4d)) {
|
|
if ((bytes[1] == 0x8b) || (bytes[1] == 0x3b)) { // movq, cmpq
|
|
if ((bytes[2] & 0xc7) == (0x80 | (PP & 7))) { // [r15+disp32]
|
|
intptr_t index = IndexFromPPLoad(pc + 3);
|
|
const ObjectPool& pool = ObjectPool::Handle(code.object_pool());
|
|
if (pool.TypeAt(index) == ObjectPool::kTaggedObject) {
|
|
*obj = pool.ObjectAt(index);
|
|
return true;
|
|
}
|
|
}
|
|
if ((bytes[2] & 0xc7) == (0x40 | (PP & 7))) { // [r15+disp8]
|
|
intptr_t index = IndexFromPPLoadDisp8(pc + 3);
|
|
const ObjectPool& pool = ObjectPool::Handle(code.object_pool());
|
|
if (pool.TypeAt(index) == ObjectPool::kTaggedObject) {
|
|
*obj = pool.ObjectAt(index);
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
COMPILE_ASSERT(THR == R14);
|
|
if ((bytes[0] == 0x49) || (bytes[0] == 0x4d)) {
|
|
if ((bytes[1] == 0x8b) || (bytes[1] == 0x3b)) { // movq, cmpq
|
|
if ((bytes[2] & 0xc7) == (0x80 | (THR & 7))) { // [r14+disp32]
|
|
int32_t offset = *reinterpret_cast<int32_t*>(pc + 3);
|
|
return Thread::ObjectAtOffset(offset, obj);
|
|
}
|
|
if ((bytes[2] & 0xc7) == (0x40 | (THR & 7))) { // [r14+disp8]
|
|
uint8_t offset = *reinterpret_cast<uint8_t*>(pc + 3);
|
|
return Thread::ObjectAtOffset(offset, obj);
|
|
}
|
|
}
|
|
}
|
|
if (((bytes[0] == 0x41) && (bytes[1] == 0xff) && (bytes[2] == 0x76))) {
|
|
// push [r14+disp8]
|
|
uint8_t offset = *reinterpret_cast<uint8_t*>(pc + 3);
|
|
return Thread::ObjectAtOffset(offset, obj);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
intptr_t TypeTestingStubCallPattern::GetSubtypeTestCachePoolIndex() {
|
|
const intptr_t kCallPatternSize = 10;
|
|
static int16_t pattern[kCallPatternSize] = {
|
|
0x4d, 0x8b, 0x8f, -1, -1, -1, -1, // movq R9, [PP + offs]
|
|
0xff, 0x53, 0x07 // callq [RBX+ 0x7]
|
|
};
|
|
const uword start = pc_ - kCallPatternSize;
|
|
ASSERT(MatchesPattern(start, pattern, kCallPatternSize));
|
|
|
|
return IndexFromPPLoad(start + 3);
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_X64
|