Alexander Markov
344c68e54c
Metadata is no longer written ahead of all nodes. Instead, metadata for each node is written in the same context as the node itself (into a separate buffer). This allows metadata to contain (serialize) arbitrary nodes (for example, arbitrary DartTypes) and use serialization context of parent nodes (such as declared type parameters). However, with this change metadata looses the ability to reference arbitrary AST nodes. This ability was overly restricted and had no practical uses. (It was not possible to reference nodes which are not reachable from root Component. As a consequence, it was not possible to write references to arbitrary DartTypes.) This change aligns the serialization capabilities of metadata with how kernel AST nodes are serialized. Change-Id: I027299a33b599b62572eccd4aa7083ad1dd2b3b3 Reviewed-on: https://dart-review.googlesource.com/54481 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Jens Johansen <jensj@google.com>
53 lines
1.7 KiB
Dart
53 lines
1.7 KiB
Dart
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
library vm.metadata.direct_call;
|
|
|
|
import 'package:kernel/ast.dart';
|
|
|
|
/// Metadata for annotating method invocations converted to direct calls.
|
|
class DirectCallMetadata {
|
|
final Reference _targetReference;
|
|
final bool checkReceiverForNull;
|
|
|
|
DirectCallMetadata(Member target, bool checkReceiverForNull)
|
|
: this.byReference(getMemberReference(target), checkReceiverForNull);
|
|
|
|
DirectCallMetadata.byReference(
|
|
this._targetReference, this.checkReceiverForNull);
|
|
|
|
Member get target => _targetReference.asMember;
|
|
|
|
@override
|
|
String toString() => "${target}${checkReceiverForNull ? '??' : ''}";
|
|
}
|
|
|
|
/// Repository for [DirectCallMetadata].
|
|
class DirectCallMetadataRepository
|
|
extends MetadataRepository<DirectCallMetadata> {
|
|
@override
|
|
final String tag = 'vm.direct-call.metadata';
|
|
|
|
@override
|
|
final Map<TreeNode, DirectCallMetadata> mapping =
|
|
<TreeNode, DirectCallMetadata>{};
|
|
|
|
@override
|
|
void writeToBinary(DirectCallMetadata metadata, Node node, BinarySink sink) {
|
|
sink.writeCanonicalNameReference(getCanonicalNameOfMember(metadata.target));
|
|
sink.writeByte(metadata.checkReceiverForNull ? 1 : 0);
|
|
}
|
|
|
|
@override
|
|
DirectCallMetadata readFromBinary(Node node, BinarySource source) {
|
|
final targetReference = source.readCanonicalNameReference()?.getReference();
|
|
if (targetReference == null) {
|
|
throw 'DirectCallMetadata should have a non-null target';
|
|
}
|
|
final checkReceiverForNull = (source.readByte() != 0);
|
|
return new DirectCallMetadata.byReference(
|
|
targetReference, checkReceiverForNull);
|
|
}
|
|
}
|