This has little negative impact on the completion metrics and some
positive impact in several places. The impact is fairly small overall,
but still worth having in my opinion. The biggest improvement is at the
beginning of a statement. The overall changes in relevance and relevance
by element kind (lower is better) are:
shipping | keyword type delta
all completions 4.013 | 3.930 -0.083
successful completions 3.995 | 3.912 -0.083
class 28.359 | 28.325 -0.034
constructor 4.739 | 4.739 0.000
enum 12.928 | 12.928 0.000
instance member 3.273 | 3.153 -0.120
keyword dynamic 136.713 | 136.223 -0.490
keyword void 239.200 | 227.453 -11.747
local function 161.336 | 161.340 0.004
local variable 1.632 | 1.616 -0.015
parameter 4.406 | 4.383 -0.023
prefix 363.871 | 368.868 4.997
static member 6.012 | 5.984 -0.028
top level member 12.443 | 12.443 0.000
type parameter 252.785 | 254.135 1.350
Change-Id: Ia449feb716bfd6150f0204885e05fc0e812f1448
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184861
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Brian Wilkerson
bf8b510a8b