Paul Berry
d9f191575a
Replaces the top level function `analyzeAnalysisOptions`, which contained 3 nested local functions, with a class `AnalyzeAnalysisOptions`, where the nested local functions have been changed into private methods. All the variables in the top level function that were implicitly write- or read-captured by the nested local functions have been changed into class fields or explicit method parameters. This should make the code a lot easier to follow. In this CL, I've tried hard to preserve the existing functionality exactly; besides converting local variables to fields and parameters, I haven't really made any changes to the core logic beyond code motion. In follow-up CLs, I plan to make some simplifications that are less obviously semantics preserving (but should be easier to review since they won't involve so much code motion). Once that is done I hope to be able to migrate the error reporting in this class to use the literate diagnostic API. Change-Id: I6a6a696414ecae80535c8d6633eaa567d37dcccc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/479080 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
SDK development code analysis
dartanalyzer used to be the tool for statically analyzing dart code
at the command line. However, this tool has been replaced with
dart analyze for this purpose in current SDKs and will no longer
be published on pub.
Do not depend on the command line interface or other semantics in
this directory as it is now an internal tool for SDK development, used
as the dart2analyzer "compiler" for tools/test.py in the SDK.
It is configured as part of the test runner,
here.
SDK development usage
For SDK development, run analysis from the test tool to validate analysis conclusions on language samples in the testing directory. From the root of the SDK:
tools/test.py --build --use-sdk -c dart2analyzer co19 language
This will build the Dart VM and compile dartanalyzer into a snapshot, then use
that snapshot while analyzing those directories under testing/. Without
--use-sdk, test.py will use the source code version of the analyzer
instead of the compiled one, which can be useful for debugging.