Paul Berry
430df693b9
It looks like a recent commit accidentally left `updatingIsEnabled` set to `true`. This should never be done, because it makes all tests that use `NodeTextExpectationsCollector` silently pass on trybots. To help prevent this happening by mistake again in the future, I've added a presubmit check that will prevent a CL from being uploaded that changes the `updatingIsEnabled` to `true`. Change-Id: I8380e0ac1f425c64e62483f64916de6a804052e7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337840 Auto-Submit: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
46 lines
1.8 KiB
Python
46 lines
1.8 KiB
Python
#!/usr/bin/env python3
|
|
# Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
"""Analyzer specific presubmit script.
|
|
|
|
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
|
|
for more details about the presubmit API built into gcl.
|
|
"""
|
|
|
|
import os.path
|
|
import re
|
|
|
|
USE_PYTHON3 = True
|
|
PRESUBMIT_VERSION = '2.0.0'
|
|
|
|
|
|
def CheckNodeTextExpectationsCollectorUpdatingIsDisabled(input_api, output_api):
|
|
local_root = input_api.change.RepositoryRoot()
|
|
node_text_expectations_file = os.path.join(local_root, 'pkg', 'analyzer',
|
|
'test', 'src', 'dart',
|
|
'resolution',
|
|
'node_text_expectations.dart')
|
|
for git_file in input_api.AffectedTestableFiles():
|
|
filename = git_file.AbsoluteLocalPath()
|
|
if (filename == node_text_expectations_file):
|
|
isEnabledLine = re.compile('static const updatingIsEnabled = (.*);')
|
|
for line in git_file.NewContents():
|
|
m = isEnabledLine.search(line)
|
|
if (m is not None):
|
|
value = m.group(1)
|
|
if (value == 'false'):
|
|
return []
|
|
else:
|
|
return [
|
|
output_api.PresubmitError(
|
|
'NodeTextExpectationsCollector.updatingIsEnabled '
|
|
'must be `false`')
|
|
]
|
|
return [
|
|
output_api.PresubmitError(
|
|
'Could not validate '
|
|
'NodeTextExpectationsCollector.updatingIsEnabled')
|
|
]
|
|
return []
|