Paul Berry
87b2f50c5c
This change refactors the `_attachFinally` method in `_FlowAnalysisImpl` to better align with the flow analysis specification. Notable changes include: - Moving `attachFinally` to the `FlowAnalysisImpl` class rather than implicitly passing the `afterTry` model as `this`. This makes the arguments to `attachFinally` match those in the spec. - Extracting the handling of a single variable to a separate function, `attachFinallyV`, to align with the spec. - Renaming local variables to match variable names in the spec. - Adding comments that refer to specific spec language. - Adding parenthetical "OPTIMIZATION:" comments to document differences between the implementation and spec that are for the purpose of efficiency and don't affect behavior. - Adding parenthetical "UNSPECIFIED:" comments to documented differences between the implementaiton and spec that reflect flow analysis features that haven't been documented yet. - Adding comments that directly reference the `attachFinally` and `attachFinallyV` sections of the specification. - Reordering logic to more closely follow the structure of the specification. This is a pure refactoring and does not change the behavior of flow analysis. Change-Id: I6a6a6964bd76b87102facf4251b195e5604c7c32 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445780 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.