dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
85a4fdb81a7fc4e49a9a675684d0359122600a09
sdk/runtime/lib
T
History
Todd Volkert 9173aed1ba Declare return types of Uint8List. 
These methods all were returning Uint8List, yet they were only
declared to return List<int>. This forced callers to either defensively
wrap the return values in Uint8List, or to assume the contravariant
return value:

* Utf8Codec.encode()
* BytesBuilder.takeBytes()
* BytesBuilder.toBytes()
* File.readAsBytes()
* File.readAsBytesSync()
* RandomAccessFile.read()
* RandomAccessFile.readSync()
* Uint8List.sublist()

Since it's related, this change also updates the following sublist()
methods to declare that they return the a sublist of the same type as
the source list:

* Int8List
* Uint8ClampedList
* Int16List
* Uint16List
* Int32List
* Uint32List
* Int64List
* Uint64List
* Float32List
* Float64List
* Float32x4List
* Int32x4List
* Float64x2List

Bug: https://github.com/dart-lang/sdk/issues/36900
Bug: https://github.com/dart-lang/sdk/issues/31547
Bug: https://github.com/dart-lang/sdk/issues/27818
Bug: https://github.com/dart-lang/sdk/issues/35521
Change-Id: Ic3bc1db0d64de36fb68b1d8d98037eed1464f978
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101742
Commit-Queue: Todd Volkert <tvolkert@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2019-06-20 06:43:44 +00:00
..
array_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
array.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
array.dart
Optimize VM List's setAll method.
2018-11-15 19:08:09 +00:00
async_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
async_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
async.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
bigint_patch.dart
[corelib BigInt] Fix implementation of BigInt.modInverse (fixes issue #37008).
2019-05-25 22:05:51 +00:00
bool_patch.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00
bool.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
class_id_fasta.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
class_id.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
class_id.dart
Reland "[VM] Inline ClassID.getID() eagerly, extend pattern matching logic to recognize it, use it to special case ascii decoding"
2018-11-28 10:43:32 +00:00
collection_patch.dart
[vm] Remove redundant type-checks from core libraries.
2019-01-14 19:56:37 +00:00
collection_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
compact_hash.dart
[VM] Rehash sets after they are read from a snapshot.
2019-02-21 19:39:09 +00:00
convert_patch.dart
[vm/aot] Remove special casing of td views, allow external/internal typed data to be fast as well in string decoding
2019-04-08 15:06:03 +00:00
convert_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
core_patch.dart
[vm] Remove Dart 1 enum implementation.
2019-06-12 19:26:32 +00:00
core_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
date_patch.dart
Cleanup unused vars in VM patch files
2018-11-13 22:56:54 +00:00
date.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
deferred_load_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
developer_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
developer.cc
[vm] Use std::unique_ptr with Message
2019-05-06 21:01:39 +00:00
developer.dart
[ dart:developer ] Exposed reason, errorCode, and errorDetail getters in ServiceExtensionResult.
2019-05-28 18:02:12 +00:00
double_patch.dart
Add tryParse alternatives to parseFunctions.
2018-04-12 13:16:49 +00:00
double.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
double.dart
[VM] Add @pragma("vm:non-nullable-result-type") annotation
2018-11-22 16:18:27 +00:00
empty_source.dart
…
errors_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
errors.cc
[vm] Replace ^= assignments with = where possible
2019-05-01 00:04:44 +00:00
expando_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
ffi_dynamic_library_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
ffi_dynamic_library.cc
Fix builds targeting Android from a Windows host gen_snapshot.
2019-06-07 00:49:33 +00:00
ffi_native_type_patch.dart
[vm / library] Foreign function interface prototype
2019-02-13 12:42:47 +00:00
ffi_patch.dart
[vm/ffi] Re-land "[vm/ffi] FFI callbacks on X64."
2019-05-24 02:39:13 +00:00
ffi_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
ffi.cc
[vm/ffi] SimDBC64 align stack frame
2019-06-13 16:26:40 +00:00
ffi.h
[vm/ffi] SimDBC64 align stack frame
2019-06-13 16:26:40 +00:00
function_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
function.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
function.dart
[vm] Harden access to unchecked natives.
2019-06-12 21:32:33 +00:00
growable_array.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
growable_array.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
identical_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
identical.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
immutable_map.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00
integers_patch.dart
Rephrase FormatException for int.parse
2019-01-03 22:43:43 +00:00
integers.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
integers.dart
[vm] Harden access to unchecked natives.
2019-06-12 21:32:33 +00:00
internal_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
internal_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
invocation_mirror_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
invocation_mirror.h
Revert "Revert "Dart Core Lib change to support generic functions in class NoSuchMethodError.""
2017-09-28 00:27:24 +00:00
isolate_patch.dart
[vm/isolate] Add TransferableTypedData class that allows low-cost passing of Uint8List between isolates.
2019-06-06 19:49:07 +00:00
isolate_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
isolate.cc
[vm] Use std::unique_ptr for ThreadPool::Task
2019-06-18 17:51:10 +00:00
lib_prefix.dart
[vm] Harden access to unchecked natives.
2019-06-12 21:32:33 +00:00
libgen_in.cc
…
linked_hash_map.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
map_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
math_patch.dart
Cleanup unused vars in VM patch files
2018-11-13 22:56:54 +00:00
math_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
math.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
mirror_reference.dart
[vm] Harden access to unchecked natives.
2019-06-12 21:32:33 +00:00
mirrors_impl.dart
Report noSuchMethod forwarders as synthetic in the mirror api
2019-02-14 18:42:19 +00:00
mirrors_patch.dart
Changes to runtime patches so Fasta can understand them.
2017-11-01 15:16:04 +00:00
mirrors_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
mirrors.cc
[vm] Censor mirroring of dart:ffi when --enable-ffi=false
2019-06-06 20:32:27 +00:00
mirrors.h
Report noSuchMethod forwarders as synthetic in the mirror api
2019-02-14 18:42:19 +00:00
null_patch.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00
object_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
object.cc
[VM Runtime] Removed 'IsMoreSpecificThan' support in the VM.
2019-01-03 00:41:20 +00:00
print_patch.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00
profiler_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
profiler.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
profiler.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00
regexp_patch.dart
[vm] Harden access to unchecked natives.
2019-06-12 21:32:33 +00:00
regexp.cc
Reland "[vm] Finish adding support for ECMAScript 2018 features."
2019-04-29 09:11:48 +00:00
schedule_microtask_patch.dart
[vm/aot] Remove unnecessary closurization of some entry-points.
2019-02-20 10:44:21 +00:00
simd128.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
stacktrace.cc
[vm, interpreter] Handle implicit static getters as bytecode.
2019-04-17 19:48:37 +00:00
stacktrace.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00
stacktrace.h
…
stopwatch_patch.dart
Fix Stopwatch timers to not overflow on intermediate computations.
2019-02-27 09:56:12 +00:00
stopwatch.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
string_buffer_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
string_patch.dart
[vm] Harden access to unchecked natives.
2019-06-12 21:32:33 +00:00
string.cc
[vm] Replace ^= assignments with = where possible
2019-05-01 00:04:44 +00:00
symbol_patch.dart
Changes to runtime patches so Fasta can understand them.
2017-11-01 15:16:04 +00:00
timeline.cc
[vm] Enable timeline on Fuchsia even in product mode.
2019-01-18 00:06:10 +00:00
timeline.dart
Revert "[VM] Move runtime/lib/{developer,profiler,timeline}.dart -> ..._patch.dart, fix owner of constructors"
2018-03-13 22:24:19 +00:00
timer_impl.dart
Make _cancelWakeup a no-op if _sendPort is null
2019-03-21 18:15:27 +00:00
timer_patch.dart
[ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium.
2019-01-16 20:28:21 +00:00
type_patch.dart
[vm] Harden access to unchecked natives.
2019-06-12 21:32:33 +00:00
typed_data_patch.dart
Declare return types of Uint8List.
2019-06-20 06:43:44 +00:00
typed_data_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
typed_data.cc
Revert "Reland "Temporary revert of two changes which potentially caused performance regressions in Flutter.""
2019-04-03 12:50:57 +00:00
uri_patch.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00
uri.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
vmservice_sources.gni
Fix sources to source_set
2019-05-21 17:01:48 +00:00
vmservice.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
weak_property.cc
[vm] refactor native entry and native entry type arguments
2018-12-13 19:29:26 +00:00
weak_property.dart
[vm/precomp] Fix name of vm:entry-point.
2018-08-16 15:07:51 +00:00