Tess Strickland
844a5176ff
[vm] Fix ArgumentsDescriptor uses in DoArgumentTypesMatch.
...
Use of PositionalCount() and PositionAt() as indices in the arguments
array must account for the type arguments if present. Otherwise, we'll
either skip checking the last positional argument (in the former case)
or check against the wrong arguments (in the latter case).
In nosuchmethod_forwarding_arguments_test.dart, add cases that check for
the above mistakes.
In require_named_args_strong_test.dart, use the more specific
throwsTypeError or throwsNoSuchMethod checks instead of the generic
throwsError to ensure the correct error is thrown.
TEST=Changed tests to add extra cases for failures that can happen.
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try
Change-Id: If5e6c310d36d244bb0650ded54e32e583732584e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171947
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Tess Strickland <sstrickl@google.com >
2020-11-16 11:53:39 +00:00
..
2020-11-16 11:04:00 +00:00
2020-11-13 19:07:20 +00:00
2019-08-08 00:47:55 +00:00
2020-11-03 21:39:37 +00:00
2019-01-11 20:47:10 +00:00
2020-11-13 19:07:20 +00:00
2020-02-27 17:50:43 +00:00
2019-10-21 16:26:39 +00:00
2019-12-03 22:00:48 +00:00
2020-11-13 22:10:54 +00:00
2019-12-03 22:00:48 +00:00
2019-07-11 13:36:02 +00:00
2020-11-13 22:10:54 +00:00
2019-10-07 18:13:06 +00:00
2020-03-11 13:05:59 +00:00
2020-03-11 13:05:59 +00:00
2020-02-14 17:57:47 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2020-11-13 20:40:24 +00:00
2020-11-13 20:40:24 +00:00
2020-10-22 13:08:10 +00:00
2020-04-25 05:21:27 +00:00
2020-10-06 17:10:05 +00:00
2020-05-26 08:47:30 +00:00
2020-11-13 20:40:24 +00:00
2020-09-23 19:13:29 +00:00
2019-04-24 23:12:45 +00:00
2020-10-22 13:08:10 +00:00
2020-11-13 17:57:50 +00:00
2020-10-21 19:36:56 +00:00
2020-11-13 20:40:24 +00:00
2020-07-09 18:33:32 +00:00
2020-11-13 22:10:54 +00:00
2020-11-02 21:11:50 +00:00
2020-11-02 21:11:50 +00:00
2020-04-16 22:59:03 +00:00
2020-04-16 22:59:03 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2019-01-25 16:45:13 +00:00
2020-11-13 22:10:54 +00:00
2019-11-21 12:28:45 +00:00
2020-10-26 19:41:46 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-05-07 19:40:18 +00:00
2020-04-25 05:21:27 +00:00
2020-08-12 17:23:14 +00:00
2019-10-27 18:18:29 +00:00
2020-10-28 17:42:35 +00:00
2020-09-23 21:05:59 +00:00
2020-09-23 21:05:59 +00:00
2020-10-28 17:42:35 +00:00
2020-02-05 16:36:09 +00:00
2020-11-11 17:11:42 +00:00
2020-02-05 16:36:09 +00:00
2020-11-11 17:11:42 +00:00
2020-02-18 08:43:16 +00:00
2020-02-05 16:36:09 +00:00
2020-11-11 17:11:42 +00:00
2020-06-01 23:21:38 +00:00
2020-11-11 17:11:42 +00:00
2020-06-11 12:29:19 +00:00
2020-02-18 08:43:16 +00:00
2019-08-01 14:14:39 +00:00
2019-09-05 21:41:42 +00:00
2020-06-26 09:39:15 +00:00
2020-06-26 09:39:15 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2020-04-16 22:59:03 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2020-06-25 03:36:41 +00:00
2019-09-18 19:47:29 +00:00
2020-06-25 03:36:41 +00:00
2020-06-25 03:36:41 +00:00
2020-11-12 10:22:16 +00:00
2020-11-15 13:31:47 +00:00
2020-04-25 05:21:27 +00:00
2020-11-13 22:10:54 +00:00
2020-05-07 19:40:18 +00:00
2019-10-21 16:26:39 +00:00
2020-11-03 10:27:44 +00:00
2020-10-29 02:52:03 +00:00
2020-10-29 02:52:03 +00:00
2020-11-13 00:29:38 +00:00
2020-09-17 06:07:50 +00:00
2020-10-12 11:07:21 +00:00
2020-10-06 07:59:33 +00:00
2020-10-09 10:08:16 +00:00
2020-07-09 14:55:11 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-11-12 16:21:26 +00:00
2020-11-09 15:10:49 +00:00
2020-10-16 20:05:02 +00:00
2020-10-16 20:05:02 +00:00
2020-10-28 17:42:35 +00:00
2020-11-13 19:07:20 +00:00
2020-03-13 17:19:52 +00:00
2020-03-13 17:19:52 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-10-06 17:10:05 +00:00
2020-10-06 17:10:05 +00:00
2020-10-09 10:08:16 +00:00
2020-10-06 17:10:05 +00:00
2020-06-02 21:29:03 +00:00
2020-11-02 21:27:19 +00:00
2020-09-23 21:05:59 +00:00
2020-11-13 00:29:38 +00:00
2020-11-13 00:29:38 +00:00
2020-04-16 22:59:03 +00:00
2020-04-16 22:59:03 +00:00
2020-05-04 21:15:27 +00:00
2020-04-25 05:21:27 +00:00
2020-11-03 10:27:44 +00:00
2020-01-29 11:46:50 +00:00
2020-11-10 18:41:24 +00:00
2020-10-07 15:23:25 +00:00
2019-11-18 10:11:38 +00:00
2019-09-05 21:41:42 +00:00
2020-10-28 17:42:35 +00:00
2020-05-20 14:05:40 +00:00
2019-09-13 18:25:16 +00:00
2020-09-18 09:35:22 +00:00
2020-05-26 22:40:52 +00:00
2019-01-25 16:45:13 +00:00
2020-11-13 19:07:20 +00:00
2020-11-03 10:27:44 +00:00
2019-01-25 16:45:13 +00:00
2020-11-13 19:07:20 +00:00
2019-10-21 18:30:54 +00:00
2020-11-13 19:07:20 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-07-17 19:29:47 +00:00
2020-11-02 21:11:50 +00:00
2020-11-02 21:11:50 +00:00
2020-10-26 19:41:46 +00:00
2020-04-25 05:21:27 +00:00
2020-10-26 19:41:46 +00:00
2020-04-25 05:21:27 +00:00
2019-07-10 22:20:10 +00:00
2019-01-25 16:45:13 +00:00
2020-05-07 19:40:18 +00:00
2020-05-07 19:40:18 +00:00
2019-10-27 18:18:29 +00:00
2020-05-02 17:22:05 +00:00
2020-05-02 17:22:05 +00:00
2020-11-06 20:05:53 +00:00
2020-11-11 19:54:22 +00:00
2020-10-28 17:42:35 +00:00
2020-05-26 22:40:52 +00:00
2020-11-15 13:31:47 +00:00
2020-11-15 13:31:47 +00:00
2020-11-03 10:27:44 +00:00
2020-06-11 22:43:39 +00:00
2020-08-07 18:09:35 +00:00
2020-08-07 18:09:35 +00:00
2020-08-07 18:09:35 +00:00
2020-07-07 06:08:20 +00:00
2020-11-03 16:02:16 +00:00
2020-11-13 07:25:36 +00:00
2020-11-13 00:29:38 +00:00
2020-11-05 09:51:13 +00:00
2020-10-28 17:42:35 +00:00
2020-11-06 10:41:43 +00:00
2020-11-06 10:41:43 +00:00
2020-02-20 21:08:35 +00:00
2020-11-06 14:46:22 +00:00
2020-08-21 21:44:50 +00:00
2020-05-30 01:06:44 +00:00
2019-01-11 20:47:10 +00:00
2020-11-13 22:10:54 +00:00
2020-11-13 22:10:54 +00:00
2020-11-13 22:10:54 +00:00
2020-08-26 21:32:36 +00:00
2020-06-02 13:25:01 +00:00
2020-08-26 21:32:36 +00:00
2020-11-13 22:10:54 +00:00
2020-08-26 21:32:36 +00:00
2020-05-15 20:28:21 +00:00
2020-05-15 20:28:21 +00:00
2020-05-07 19:40:18 +00:00
2020-05-28 17:25:58 +00:00
2020-05-05 12:08:43 +00:00
2020-04-21 14:05:53 +00:00
2020-06-25 03:36:41 +00:00
2020-04-25 05:21:27 +00:00
2020-05-08 18:28:06 +00:00
2020-08-31 12:14:38 +00:00
2020-11-10 18:41:24 +00:00
2020-05-09 08:27:48 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2019-01-25 16:45:13 +00:00
2020-06-25 03:36:41 +00:00
2019-05-06 21:01:39 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-06-25 03:36:41 +00:00
2020-05-26 08:47:30 +00:00
2020-04-25 05:21:27 +00:00
2019-07-10 22:20:10 +00:00
2020-11-03 10:27:44 +00:00
2020-11-03 10:27:44 +00:00
2020-05-19 17:37:10 +00:00
2019-07-10 22:20:10 +00:00
2020-05-06 19:19:52 +00:00
2020-05-06 19:19:52 +00:00
2020-05-06 19:19:52 +00:00
2020-10-28 17:42:35 +00:00
2020-11-06 20:05:53 +00:00
2020-04-25 05:21:27 +00:00
2020-11-05 09:51:13 +00:00
2020-11-13 20:40:24 +00:00
2020-11-03 10:27:44 +00:00
2020-04-25 05:21:27 +00:00
2020-11-16 11:53:39 +00:00
2020-11-13 20:40:24 +00:00
2020-06-03 17:27:41 +00:00
2020-09-02 18:36:02 +00:00
2020-06-03 17:27:41 +00:00
2020-06-03 17:27:41 +00:00
2020-05-04 21:15:27 +00:00
2020-06-10 19:57:02 +00:00
2019-10-02 05:33:29 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-09-21 19:42:42 +00:00
2020-06-25 03:36:41 +00:00
2020-06-03 17:27:41 +00:00
2020-06-03 17:27:41 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-04-25 05:21:27 +00:00
2020-11-13 19:07:20 +00:00
2020-11-11 23:42:12 +00:00
2020-11-11 23:42:12 +00:00
2020-11-11 23:42:12 +00:00
2019-09-05 21:41:42 +00:00
2020-10-28 17:42:35 +00:00
2020-04-25 05:21:27 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-07-17 19:29:47 +00:00
2020-11-06 19:23:23 +00:00
2019-08-19 19:31:42 +00:00
2020-11-13 22:10:54 +00:00
2020-11-13 20:40:24 +00:00
2020-11-06 19:23:23 +00:00
2020-10-07 22:34:24 +00:00
2020-04-25 05:21:27 +00:00
2020-06-26 09:39:15 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2019-03-14 14:26:47 +00:00
2019-09-05 21:41:42 +00:00
2019-04-29 09:11:48 +00:00
2020-06-18 11:14:13 +00:00
2019-04-30 16:17:18 +00:00
2020-06-17 14:01:54 +00:00
2020-04-25 05:21:27 +00:00
2020-11-03 10:27:44 +00:00
2020-09-08 13:16:24 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-10-27 23:51:57 +00:00
2020-10-16 19:22:52 +00:00
2020-10-28 17:42:35 +00:00
2020-08-12 17:23:14 +00:00
2020-08-12 17:23:14 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2019-09-05 21:41:42 +00:00
2020-11-05 09:51:13 +00:00
2020-10-02 16:17:58 +00:00
2020-11-06 19:02:23 +00:00
2020-05-12 19:22:41 +00:00
2020-11-13 07:25:36 +00:00
2020-08-21 21:44:50 +00:00
2020-11-03 10:27:44 +00:00
2020-11-11 23:42:12 +00:00
2020-11-03 21:39:37 +00:00
2020-03-23 21:49:37 +00:00
2019-07-16 19:46:56 +00:00
2019-07-16 19:46:56 +00:00
2020-10-28 17:42:35 +00:00
2020-05-27 17:04:30 +00:00
2020-10-28 17:42:35 +00:00
2020-05-07 16:16:08 +00:00
2019-10-27 18:18:29 +00:00
2020-02-11 23:37:05 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-04-25 05:21:27 +00:00
2020-10-28 17:42:35 +00:00
2019-03-07 02:04:41 +00:00
2019-04-29 09:11:48 +00:00
2020-06-12 11:14:22 +00:00
2020-06-12 11:14:22 +00:00
2020-06-12 11:14:22 +00:00
2020-10-28 17:42:35 +00:00
2020-06-12 11:14:22 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-11-12 16:21:26 +00:00
2020-11-12 16:21:26 +00:00
2019-09-05 21:41:42 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-04-25 05:21:27 +00:00
2020-10-28 17:42:35 +00:00
2020-10-22 13:08:10 +00:00
2020-04-25 05:21:27 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-09-23 19:13:29 +00:00
2020-11-13 20:40:24 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2019-06-18 17:51:10 +00:00
2020-03-11 22:03:50 +00:00
2019-01-15 22:07:51 +00:00
2020-03-11 22:03:50 +00:00
2020-03-11 22:03:50 +00:00
2019-01-11 20:47:10 +00:00
2020-06-12 03:29:17 +00:00
2020-03-28 00:41:51 +00:00
2020-06-02 13:25:01 +00:00
2020-05-15 10:57:09 +00:00
2020-05-15 10:57:09 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2019-01-25 16:45:13 +00:00
2019-01-25 16:45:13 +00:00
2020-11-13 15:27:20 +00:00
2020-11-06 08:08:52 +00:00
2020-11-02 08:37:22 +00:00
2020-08-04 17:19:19 +00:00
2020-03-10 23:29:18 +00:00
2020-08-04 17:19:19 +00:00
2020-07-02 12:01:49 +00:00
2019-12-07 00:28:15 +00:00
2020-06-25 03:36:41 +00:00
2020-11-13 19:07:20 +00:00
2019-10-09 21:48:20 +00:00
2019-09-05 10:36:13 +00:00
2020-10-26 19:41:46 +00:00
2020-10-26 19:41:46 +00:00
2020-03-17 14:11:02 +00:00
2020-10-21 19:36:56 +00:00
2020-03-17 14:11:02 +00:00
2020-10-26 18:48:18 +00:00
2020-09-18 12:01:11 +00:00
2019-04-22 20:15:43 +00:00
2019-04-22 20:15:43 +00:00
2020-06-29 16:10:13 +00:00
2020-11-13 00:29:38 +00:00
2020-06-02 20:40:03 +00:00
2020-05-04 21:15:27 +00:00
2019-10-17 17:19:32 +00:00
2020-05-26 10:46:05 +00:00
2020-05-26 10:46:05 +00:00
2020-08-06 19:55:12 +00:00
2020-08-06 19:55:12 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-05-08 18:28:06 +00:00
2020-02-20 21:08:35 +00:00
2019-03-12 20:45:45 +00:00
2019-12-10 12:26:05 +00:00
2020-04-17 03:02:27 +00:00
2020-09-15 18:32:31 +00:00
2020-11-13 00:29:38 +00:00
2019-05-01 00:36:14 +00:00
2020-08-07 21:40:45 +00:00
2020-08-07 21:40:45 +00:00
2020-06-25 19:51:12 +00:00
2020-06-25 19:51:12 +00:00