Files
sdk/pkg/dartdev/lib
Ben Konyi 3495a21fc8 [ CLI ] Don't strip specific flags from argument list
Arguments matching the following patterns were being removed from the
argument list before being processed by DartDev's argument parser:

 --observe
 --enable-vm-service
 --devtools

This was due to these arguments having non-standard formats that caused
parsing issues in the past. However, these arguments are now completely
parsed by the VM and not actually decoded in the CLI, so there's no need
to blindly remove them. This was causing issues when passing arguments
to user processes (e.g., `dart run foo.dart --devtools-port` would drop
the `--devtools-port` argument due to this logic).

Fixes https://github.com/dart-lang/sdk/issues/54815

Change-Id: I09358d7f5004483ad3b457ba74229c940d9a0d75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350360
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2024-02-05 19:12:50 +00:00
..