sdk/pkg/vm at 8218ee084081eded31d35aa79ae819d6656cffd4 - sdk

Files

T

Daco Harkes 8218ee0840 [cfe/ffi] Fix Finalizable in for( in ) loops

The `Finalizable` visitor was visiting for-in loops in AST order:
(1) variable, (2) iterable, (3) body. This caused the `variable` to be
fenced in the `iterable` expression. The `variable` should only be
fenced in the `body`.

TEST=tests/ffi/regress_51538_test.dart
TEST=pkg/vm/test/transformations/ffi_test.dart
     with pkg/vm/testcases/transformations/ffi/regress_51538.dart

Closes: https://github.com/dart-lang/sdk/issues/51538
Change-Id: Idacf87b6de3ee0d2d5c6c5046060c55135593fed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286182
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>

2023-03-02 09:05:19 +00:00

bin

[vm/kernel_service] Fix native_assets.yaml discovery

2023-02-27 16:49:25 +00:00

lib

[cfe/ffi] Fix Finalizable in for( in ) loops

2023-03-02 09:05:19 +00:00

test

[vm/kernel_service] Fix native_assets.yaml discovery

2023-02-27 16:49:25 +00:00

testcases/transformations

[cfe/ffi] Fix Finalizable in for( in ) loops