Lasse R.H. Nielsen
ff5f391c0a
Make API more consistent for a few methods. Reduce the number of language features used in tests: * Never iterating an iterable, always converting it using `.toList()` first and iterating using indices (fx `setEquals`). Also require a `List` in places where an `Iterable` wasn't necessary. * Avoid doing complicated computations that are also used for the error message. Do simple check first, then recompute to get better error messages (fx `allDistinct`). Renamed some rarely used members for consistency (`stringContainsInOrder`->`containsInOrder`, where other string-contains functions just start with `contains`, and `containsOneOf` -> `containsAny` to match `Iterable.any` phrasing, and also it accepts if containing at least one, not precisely one.) Removed a function that wasn't used anywhere. Moved `assertStatementsEnabled` to `variations.dart` as `asserts`. Removed `typeAssertionsEnabled` and `checkedModeEnabled`. The former used in one place, where it was replaced with `checkedImplicitDowncasts` from `variations.dart`, the latter wasn't used anywhere. Deprecates `package:expect/minitest.dart`. It was never intended to be used for new tests, only as a help to convert existing tests written against `package:unit_test`. All existing imports marked as `// ignore: deprecated_member_use`. Change-Id: I07e21d4c0f3ccf11b82ee34af2668fdbb22264d2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352360 Reviewed-by: Slava Egorov <vegorov@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
113 lines
2.7 KiB
Dart
113 lines
2.7 KiB
Dart
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:html';
|
|
|
|
import 'package:expect/minitest.dart'; // ignore: deprecated_member_use_from_same_package
|
|
|
|
void check(element, String type, [bool supported = true]) {
|
|
expect(element is InputElement, true);
|
|
if (supported) {
|
|
expect(element.type, type);
|
|
} else {
|
|
expect(element.type, 'text');
|
|
}
|
|
}
|
|
|
|
main() {
|
|
test('hidden', () {
|
|
check(new HiddenInputElement(), 'hidden');
|
|
});
|
|
|
|
test('search', () {
|
|
check(new SearchInputElement(), 'search', SearchInputElement.supported);
|
|
});
|
|
|
|
test('text', () {
|
|
check(new TextInputElement(), 'text');
|
|
});
|
|
|
|
test('url', () {
|
|
check(new UrlInputElement(), 'url', UrlInputElement.supported);
|
|
});
|
|
|
|
test('telephone', () {
|
|
check(new TelephoneInputElement(), 'tel', TelephoneInputElement.supported);
|
|
});
|
|
|
|
test('email', () {
|
|
check(new EmailInputElement(), 'email', EmailInputElement.supported);
|
|
});
|
|
|
|
test('password', () {
|
|
check(new PasswordInputElement(), 'password');
|
|
});
|
|
|
|
test('date', () {
|
|
check(new DateInputElement(), 'date', DateInputElement.supported);
|
|
});
|
|
|
|
test('month', () {
|
|
check(new MonthInputElement(), 'month', MonthInputElement.supported);
|
|
});
|
|
|
|
test('week', () {
|
|
check(new WeekInputElement(), 'week', WeekInputElement.supported);
|
|
});
|
|
|
|
test('time', () {
|
|
check(new TimeInputElement(), 'time', TimeInputElement.supported);
|
|
if (TimeInputElement.supported) {
|
|
var element = new TimeInputElement();
|
|
var now = new DateTime.now();
|
|
element.valueAsDate = now;
|
|
expect(element.valueAsDate is DateTime, isTrue);
|
|
|
|
// Bug 8813, setting it is just going to the epoch.
|
|
//expect(element.valueAsDate, now);
|
|
}
|
|
});
|
|
|
|
test('datetime-local', () {
|
|
check(new LocalDateTimeInputElement(), 'datetime-local',
|
|
LocalDateTimeInputElement.supported);
|
|
});
|
|
|
|
test('number', () {
|
|
check(new NumberInputElement(), 'number', NumberInputElement.supported);
|
|
});
|
|
|
|
test('range', () {
|
|
check(new RangeInputElement(), 'range', RangeInputElement.supported);
|
|
});
|
|
|
|
test('checkbox', () {
|
|
check(new CheckboxInputElement(), 'checkbox');
|
|
});
|
|
|
|
test('radio', () {
|
|
check(new RadioButtonInputElement(), 'radio');
|
|
});
|
|
|
|
test('file', () {
|
|
check(new FileUploadInputElement(), 'file');
|
|
});
|
|
|
|
test('submit', () {
|
|
check(new SubmitButtonInputElement(), 'submit');
|
|
});
|
|
|
|
test('image', () {
|
|
check(new ImageButtonInputElement(), 'image');
|
|
});
|
|
|
|
test('reset', () {
|
|
check(new ResetButtonInputElement(), 'reset');
|
|
});
|
|
|
|
test('button', () {
|
|
check(new ButtonInputElement(), 'button');
|
|
});
|
|
}
|