dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
7c5b404eaf68f351959df5bd2c2ffb3ced8d5a21
sdk/tests/lib/async
T
History
Sigmund Cherem a7104c813f [tests] update periodic_timer tests to reduce flakiness. 
These tests check for lowerbounds on the time it took to fire an
event. Unfortunately, browsers may complete events ahead of time.
This has caused these tests to be flaky in dart2js and ddc [1]

In a local experiment, we've seen timers complete +-15ms from
the expected time. Most often they are around +-5ms, but those more
extreme cases do happen. Recent flakiness logs show some good samples:
* off by 1ms: [2] and [3]
* off by 4ms: [4]
* off by 13ms: [5]

This CL makes two adjustments to reduce flakiness:
* account for the fact that timers may complete early (checking that
  they are >= than the expected timeout - 40ms)
* increase intervals to 50ms in order to prevent overlap between two
  events in the worse scenario that both happen on the extreme variances
  (+15ms and -15ms respectively).

[1]: https://dart-current-results.web.app/#/filter=lib/async/periodic_timer,dart2js,ddc&showAll
[2]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766776511992750881/+/u/test_results/ignored_flaky_test_failure_logs
[3]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766798962026535617/+/u/test_results/ignored_flaky_test_failure_logs
[4]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767378609439308945/+/u/test_results/ignored_flaky_test_failure_logs
[5]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767357850408867553/+/u/test_results/ignored_flaky_test_failure_logs

Change-Id: Ib46d6f33f5c2b1458f393e8b4c75c84453e73024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331210
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2023-10-26 00:56:43 +00:00
..
async_await_sync_completer_test.dart
…
async_await_zones_test.dart
…
async_no_await_zones_test.dart
…
catch_errors2_test.dart
…
catch_errors3_test.dart
…
catch_errors4_test.dart
…
catch_errors5_test.dart
…
catch_errors6_test.dart
…
catch_errors7_test.dart
…
catch_errors8_test.dart
…
catch_errors11_test.dart
…
catch_errors12_test.dart
…
catch_errors13_test.dart
…
catch_errors14_test.dart
…
catch_errors15_test.dart
…
catch_errors16_test.dart
…
catch_errors17_test.dart
…
catch_errors18_test.dart
…
catch_errors19_test.dart
…
catch_errors20_test.dart
…
catch_errors21_test.dart
…
catch_errors22_test.dart
…
catch_errors23_test.dart
…
catch_errors24_test.dart
…
catch_errors25_test.dart
…
catch_errors26_test.dart
…
catch_errors27_test.dart
…
catch_errors28_test.dart
…
catch_errors_test.dart
…
catch_errors.dart
Add onError extension method to Future.
2021-01-21 23:13:56 +00:00
dart2js_uncaught_error_test.dart
…
event_helper.dart
Remove uses of : as default value separator in some tests/ directories.
2022-09-07 14:49:17 +00:00
first_regression_test.dart
…
future_constructor2_test.dart
…
future_constructor_test.dart
…
future_delayed_error_test.dart
…
future_error_test.dart
Remove uses of, and need for, Expect.throwsNullCheckedError.
2020-11-11 13:30:30 +00:00
future_extension_test.dart
Spelling tests
2022-12-19 12:56:47 +00:00
future_foreach_test.dart
…
future_future_test.dart
Fix errors in Future implementation around Future<Future<X>>.
2020-12-14 16:34:28 +00:00
future_iterable_extension_test.dart
Typo in future_iterable_extension_test
2023-04-17 08:20:14 +00:00
future_microtask_test.dart
…
future_onerror_test.dart
Update Future.onError extension method.
2023-02-18 12:01:45 +00:00
future_or_bad_type_test.dart
Migrate corelib and lib tests off @compile-error.
2023-04-20 19:19:01 +00:00
future_or_only_in_async_test.dart
…
future_or_strong_test.dart
…
future_or_type_test.dart
…
future_record_extension_test.dart
Add record-related wait extensions on Future tuples.
2023-04-04 11:39:49 +00:00
future_regression_48493_test.dart
Reland "Fix bug in Completer.complete."
2023-05-02 19:33:57 +00:00
future_test.dart
Refactor tests away from onError which is deprecated
2022-09-07 14:42:27 +00:00
future_timeout_test.dart
…
future_value_chain2_test.dart
…
future_value_chain3_test.dart
…
future_value_chain4_test.dart
…
future_value_chain_test.dart
…
futures_test.dart
…
intercept_print1_test.dart
…
intercept_schedule_microtask1_test.dart
…
intercept_schedule_microtask2_test.dart
…
intercept_schedule_microtask3_test.dart
…
intercept_schedule_microtask4_test.dart
…
intercept_schedule_microtask5_test.dart
…
intercept_schedule_microtask6_test.dart
…
multiple_timer_test.dart
…
null_future_zone_test.dart
Revert "Make nullFuture be per-zone."
2022-06-24 14:13:39 +00:00
periodic_timer2_test.dart
[tests] update periodic_timer tests to reduce flakiness.
2023-10-26 00:56:43 +00:00
periodic_timer3_test.dart
[tests] update periodic_timer tests to reduce flakiness.
2023-10-26 00:56:43 +00:00
periodic_timer4_test.dart
[tests] update periodic_timer tests to reduce flakiness.
2023-10-26 00:56:43 +00:00
regress46319_test.dart
[ddc] Add unspecified nullability regression test
2021-06-10 20:18:53 +00:00
regress154963234_strong_test.dart
…
regress154963234_weak_test.dart
…
run_zoned1_test.dart
…
run_zoned4_test.dart
…
run_zoned5_test.dart
…
run_zoned6_test.dart
…
run_zoned7_test.dart
…
run_zoned8_test.dart
…
run_zoned9_test.dart
Refactor tests away from onError which is deprecated
2022-09-07 14:42:27 +00:00
schedule_microtask2_test.dart
…
schedule_microtask3_test.dart
…
schedule_microtask5_test.dart
…
schedule_microtask_test.dart
…
slow_consumer2_test.dart
Add interface to a few classes which had missed it.
2023-05-24 14:04:27 +00:00
slow_consumer3_test.dart
Add interface to a few classes which had missed it.
2023-05-24 14:04:27 +00:00
slow_consumer_test.dart
Add interface to a few classes which had missed it.
2023-05-24 14:04:27 +00:00
stack_trace01_test.dart
…
stack_trace02_test.dart
…
stack_trace03_test.dart
…
stack_trace04_test.dart
…
stack_trace05_test.dart
…
stack_trace06_test.dart
…
stack_trace07_test.dart
…
stack_trace08_test.dart
…
stack_trace09_test.dart
…
stack_trace10_test.dart
…
stack_trace11_test.dart
…
stack_trace12_test.dart
…
stack_trace13_test.dart
…
stack_trace14_test.dart
…
stack_trace15_test.dart
…
stack_trace16_test.dart
…
stack_trace17_test.dart
…
stack_trace18_test.dart
…
stack_trace19_test.dart
…
stack_trace20_test.dart
…
stack_trace21_test.dart
…
stack_trace22_test.dart
…
stack_trace23_test.dart
…
stack_trace24_test.dart
…
stack_trace25_test.dart
…
stream_controller_add_error_test.dart
Remove uses of, and need for, Expect.throwsNullCheckedError.
2020-11-11 13:30:30 +00:00
stream_controller_async_test.dart
…
stream_controller_test.dart
…
stream_distinct_test.dart
…
stream_empty_test.dart
Fix behavior of Stream.empty.
2023-08-17 15:26:59 +00:00
stream_error_test.dart
…
stream_event_transformed_test.dart
…
stream_first_where_test.dart
…
stream_from_futures_test.dart
…
stream_from_iterable_test.dart
Refactor to implement Stream.fromIterator more directly.
2022-06-16 11:39:30 +00:00
stream_iterator_double_cancel_test.dart
…
stream_iterator_test.dart
Harden StreamIterator against out-of-order events.
2020-10-16 20:20:02 +00:00
stream_join_test.dart
…
stream_last_where_test.dart
…
stream_listen_zone_test.dart
…
stream_multi_test.dart
…
stream_periodic2_test.dart
…
stream_periodic3_test.dart
…
stream_periodic4_test.dart
…
stream_periodic5_test.dart
…
stream_periodic6_test.dart
…
stream_periodic_test.dart
…
stream_single_test.dart
…
stream_single_to_multi_subscriber_test.dart
…
stream_state_helper.dart
Spelling tests
2023-01-19 16:24:29 +00:00
stream_state_nonzero_timer_test.dart
…
stream_state_test.dart
…
stream_subscription_as_future_test.dart
…
stream_subscription_cancel_test.dart
…
stream_take_test.dart
…
stream_timeout_test.dart
…
stream_transform_test.dart
…
stream_transformation_broadcast_test.dart
…
stream_transformer_from_bind_test.dart
…
stream_transformer_from_handlers_test.dart
…
stream_transformer_test.dart
…
stream_type_test.dart
…
stream_value_test.dart
…
stream_view_test.dart
…
stream_zones_test.dart
…
syncstar_mixed_iterators_test.dart
[vm] Cleanup old async/async*/sync* implementation from kernel
2022-07-11 18:12:41 +00:00
timer_cancel1_test.dart
…
timer_cancel2_test.dart
…
timer_cancel_test.dart
…
timer_isActive_test.dart
…
timer_repeat_test.dart
…
timer_test.dart
…
unawaited_error_test.dart
[cfe] Add UnresolvedKind for fine grained unresolved reporting
2021-08-25 09:51:54 +00:00
unawaited_test.dart
Make unawaited accept a nullable argument.
2021-09-27 11:58:16 +00:00
uncaught_error_handler_throws_test.dart
Reland "Make throwing Zone.uncaughtError handlers propagate the error to their parent zone."
2021-04-23 05:24:41 +00:00
wait_for_cancel_test.dart
…
zone_async_error_test.dart
Remove uses of, and need for, Expect.throwsNullCheckedError.
2020-11-11 13:30:30 +00:00
zone_bind_callback_test.dart
…
zone_bind_callback_unary_test.dart
…
zone_bind_test.dart
…
zone_create_periodic_timer_test.dart
…
zone_create_timer2_test.dart
…
zone_create_timer_test.dart
…
zone_debug_test.dart
…
zone_empty_description2_test.dart
…
zone_empty_description_test.dart
…
zone_error_callback_test.dart
…
zone_fork_test.dart
…
zone_future_schedule_microtask_test.dart
…
zone_register_callback_test.dart
…
zone_register_callback_unary_test.dart
…
zone_root_bind_test.dart
…
zone_run_guarded_test.dart
…
zone_run_test.dart
…
zone_run_unary_test.dart
…
zone_value_test.dart
Fixed various typos in a lot of files
2022-07-25 12:21:59 +00:00