Clement Skau
f2dfe3a8be
The async, off-stack part of DebuggerStackTrace::CollectAwaiterReturn's stack unwinding incorrectly looked on the stack instead of following the Closure's awaiter chain. This caused the async stack traces to be truncated and missing any async frames, in turn causing ShouldPauseOnException to incorrectly conclude no handler frame existing. This would affect any case where the exception handling was located around any except for the inner most awaiter. TEST=Added regression test to pause_on_unhandled_exceptions_catcherror_test Closes: https://github.com/dart-lang/sdk/issues/37953 Bug: https://github.com/dart-lang/sdk/issues/37953 Change-Id: I34a2b5ce3c7532032b2ef3dfbc2af7294d13a4c7 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187405 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency