77bf16396e
* Re-implement `PubspecFixRequestResult` as a Record. This was a class with two final fields, and the class is always immediately deconstructed, so it seems like a fine case for a Record. That being said, if this is "surprising", we can go back to a full class. I don't think there is a performance change; just API. * 4 fields and 1 method on BulkFixProcessor can be private. Making one of these private enables promotion, removing the need for local shadowing variables. * 2 fields on BulkFixProcessor can be visibleForTesting. * 6 fields and 1 getter on IterativeBulkFixProcessor can be made private. * Update doc comments to be more idiomatic. Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try Change-Id: I45ba8cbd428e281727cfc4dfba712be72d3325f7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377622 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>