Paul Berry
0b94228695
This change ensures that the only types ever passed to ErrorReporter arguments are String, DartType, int, Uri, or Element. A few call sites had to be changed so that instead of passing in AST nodes they passed in the result of calling `toString` on those AST nodes. In future CLs, I plan to move toward a system where instead of passing the message arguments to ErrorReporter as a list of `Object`, we call a `withArguments` method that's specific to each error; that method will have a specific list of argument types that it supports, so that if we accidentally pass the wrong things into an error message, the problem will be detected at compile time (instead of the user just seeing a confusing error message). The `withArguments` methods will be code generated from annotations in the analyzer's `messages.yaml` file. Keeping the set of types supported by those `withArguments` messages small should help simplify the code generation process, and provide flexibility for how errors are represented in the future. Change-Id: I4a793db2fe5b1344199b770898634b61be41ad11 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216301 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency