Tess Strickland
7558e63725
The debugger assumes a null suspend state variable in an asynchronous function means that the function is still in the prologue prior to setting up the suspend state. However, the interpreter clears the suspend state variable before returning, and the debugger needs to be able to pause before returning when single stepping, so earlier a hack was added to the debugger that detects being at the direct call of the async return method and/or the return instruction with a null suspend state variable. However, there's a much simpler way of ensuring the debugger pauses before returning: just emit the source position for the return prior to clearing the suspend state variable. This also ensures that the debugger still has access to the function's suspend state when pausing before the return, instead of waiting until it has been cleared and thus is no longer accessible. TEST=ci (should not change the result of any current tests) Cq-Include-Trybots: luci.dart.try:vm-dyn-linux-debug-x64-try Change-Id: I401cceb169d8692ac379cdc5a531e07cafbe9a65 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/500740 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.