Files

T

Siva Annamalai 74c5aa3a7a Revert ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory""

This reverts commit f81a402aa1.

Reason for revert: golem benchmarks are failing to run

TEST=ci

Original change's description:
> "[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory"
>
> Fixed golem breakage by temporarily copying dartaotruntime to dart_precompiled_runtime
>
> This reverts commit 75e6a748f7.
>
> TEST=ci
>
> Original change's description:
> > Revert "[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory"
> >
> > This reverts commit 1b331d05c2.
> >
> > Reason for revert: golem builds are failing
> >
> > Original change's description:
> > > [SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory
> > >
> > > TEST=ci
> > >
>
> Change-Id: Id0f383eabb496c06c0acebc639c8e3b056ba82d0
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393781
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

Change-Id: Iec494940412aa31dbefdc5280e35ae99e8cecb26
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393764
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Siva Annamalai <asiva@google.com>

2024-11-06 05:37:46 +00:00

1.1 KiB

Raw Blame History

Important

This page was copied from https://github.com/dart-lang/sdk/wiki and needs review. Please contribute changes to bring it up-to-date - removing this header - or send a CL to delete the file.

Developer notes for working on kernel

How to test changes on pkg/kernel:

Run dartanalyzer in strong mode:

(cd pkg/kernel && dartanalyzer --strong bin lib test)

Run unit tests of kernel, front_end, and dart2js that are directly affected:

./tools/test.py pkg/kernel -mrelease --checked
./tools/test.py pkg/front_end -mrelease --checked
./tools/test.py dart2js/kernel -mrelease --checked

Run end-to-end tests using dartk + VM:

./tools/test.py -m release -c dartk language

Optionally (this is slow) run end-to-end tests using AOT:

./tools/build.py dart_precompiled_runtime
./tools/test.py -cdartkp -rdart_precompiled language co19

Comparing the output of compiling dart2js before and after the change. This script can make it easier to compare the results.

1.1 KiB Raw Blame History

Developer notes for working on kernel

How to test changes on pkg/kernel:

1.1 KiB

Raw Blame History