Danny Tuppeny
9e1dbb8be2
This code appears redundant. It was adding contexts to the declarations tracker as contexts changed, but this was also being done once at the end (in the method "addContextsToDeclarationsTracker" mentioned in the comment). Apparently at some point I added a TODO suspecting this was unnecessary but didn't realise the performance implications of it on a large project. There are existing tests that ensure the declarations are tracked correctly (although we don't use them for completions, they're still used to resolve macros in dartdocs). See https://github.com/dart-lang/sdk/issues/54513 Change-Id: Ibdb7d00c288e78fc44c48a4f9febff688e2db323 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344702 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>