Lasse R.H. Nielsen
b06a34fc5a
This never worked. It was silently accepted, at least if the future had no listeners, then any later attempt to use the future would cause a stack overflow or other impossible results. Moves some `_Future._complete` call out of try-catch. The `_complete` shouldn't throw (but before this fix it could). Moving them out of the `try`/`catch` makes such errors be reported as unhandled, instead of catching them and trying to complete the same future again with an error, when it's possibly in an inconsistent state. Fixes #43662. Based on https://github.com/dart-lang/sdk/issues/43662#issuecomment-2058870247 CoreLibraryReviewExempt: No response. Bug: http://dartbug.com/43662 Change-Id: I96a4f01bcd5b6cee93bba267299852569a9b905c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363060 Commit-Queue: Lasse Nielsen <lrn@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
33 lines
981 B
Dart
33 lines
981 B
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:async_helper/async_helper.dart';
|
|
import 'package:expect/expect.dart';
|
|
|
|
import 'catch_errors.dart';
|
|
|
|
main() {
|
|
asyncStart();
|
|
var completer = new Completer();
|
|
var errorHandlerOrDoneHasBeenExecuted = false;
|
|
// Test that `catchErrors` doesn't shut down if a future is never completed.
|
|
catchErrors(() {
|
|
completer.future.then((x) {
|
|
Expect.fail("should not be executed");
|
|
});
|
|
}).listen((x) {
|
|
errorHandlerOrDoneHasBeenExecuted = true;
|
|
Expect.fail("should not be executed (listen)");
|
|
}, onDone: () {
|
|
errorHandlerOrDoneHasBeenExecuted = true;
|
|
Expect.fail("should not be executed (onDone)");
|
|
});
|
|
Timer.run(() {
|
|
Expect.isFalse(errorHandlerOrDoneHasBeenExecuted);
|
|
asyncEnd();
|
|
});
|
|
}
|