Lasse R.H. Nielsen
b06a34fc5a
This never worked. It was silently accepted, at least if the future had no listeners, then any later attempt to use the future would cause a stack overflow or other impossible results. Moves some `_Future._complete` call out of try-catch. The `_complete` shouldn't throw (but before this fix it could). Moving them out of the `try`/`catch` makes such errors be reported as unhandled, instead of catching them and trying to complete the same future again with an error, when it's possibly in an inconsistent state. Fixes #43662. Based on https://github.com/dart-lang/sdk/issues/43662#issuecomment-2058870247 CoreLibraryReviewExempt: No response. Bug: http://dartbug.com/43662 Change-Id: I96a4f01bcd5b6cee93bba267299852569a9b905c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363060 Commit-Queue: Lasse Nielsen <lrn@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
82 lines
2.2 KiB
Dart
82 lines
2.2 KiB
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:async_helper/async_helper.dart';
|
|
import 'package:expect/expect.dart';
|
|
|
|
import 'catch_errors.dart';
|
|
|
|
main() {
|
|
asyncStart();
|
|
Completer done = new Completer();
|
|
|
|
var events = [];
|
|
late StreamController controller;
|
|
late Stream stream;
|
|
// Test that errors are not traversing zone boundaries.
|
|
// Note that the first listener of `asBroadcastStream` determines in which
|
|
// zone the subscription lives.
|
|
catchErrors(() {
|
|
catchErrors(() {
|
|
controller = new StreamController();
|
|
|
|
// Assign to "global" `stream`.
|
|
stream = controller.stream.map((x) {
|
|
events.add("map $x");
|
|
return x + 100;
|
|
}).transform(
|
|
new StreamTransformer.fromHandlers(handleError: (e, st, sink) {
|
|
sink.add("error $e");
|
|
})).asBroadcastStream();
|
|
|
|
// Listen to `stream` in the inner zone.
|
|
stream.listen((x) {
|
|
events.add("stream $x");
|
|
});
|
|
})
|
|
.listen((x) {
|
|
events.add(x);
|
|
})
|
|
.asFuture()
|
|
.then((_) {
|
|
Expect.fail("Unexpected callback");
|
|
});
|
|
|
|
// Listen to `stream` in the outer zone.
|
|
stream.listen((x) {
|
|
events.add("stream2 $x");
|
|
});
|
|
|
|
// Feed the controller from the outer zone.
|
|
controller.add(1);
|
|
// `addError` does not count as zone-traversal. It should be caught by
|
|
// the inner error handler.
|
|
controller.addError("inner error");
|
|
new Future.error("caught by outer");
|
|
controller.close();
|
|
}).listen((x) {
|
|
events.add("outer: $x");
|
|
if (x == "caught by outer") done.complete(true);
|
|
}, onDone: () {
|
|
Expect.fail("Unexpected callback");
|
|
});
|
|
|
|
done.future.whenComplete(() {
|
|
// Give handlers time to run.
|
|
Timer.run(() {
|
|
Expect.listEquals([
|
|
"map 1",
|
|
"stream 101",
|
|
"stream2 101",
|
|
"stream error inner error",
|
|
"stream2 error inner error",
|
|
"outer: caught by outer",
|
|
], events);
|
|
asyncEnd();
|
|
});
|
|
});
|
|
}
|