Files
sdk/pkg/linter/test/rules/avoid_empty_else_test.dart
T
Parker Lougheed aabc9badd0 [linter] Add some not-bad examples to avoid_empty_else
Fixes https://github.com/dart-lang/site-www/issues/5341

Also migrates its tests to reflective tests.

Change-Id: I3171aedc304347bd24aa757b3f9d77351bb75cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342280
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Marya Belanger <mbelanger@google.com>
Commit-Queue: Marya Belanger <mbelanger@google.com>
2023-12-19 23:18:53 +00:00

95 lines
1.6 KiB
Dart

// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:test_reflective_loader/test_reflective_loader.dart';
import '../rule_test_support.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(AvoidEmptyElseTest);
});
}
@reflectiveTest
class AvoidEmptyElseTest extends LintRuleTest {
@override
String get lintRule => 'avoid_empty_else';
test_else_emptyStatement_hasElseIf() async {
await assertDiagnostics(r'''
void f() {
var x = 0;
var y = 1;
if (x > y)
print('');
else if (x < y)
print('');
else ;
print('');
}
''', [
lint(105, 1),
]);
}
test_else_emptyStatement_noElseIf() async {
await assertDiagnostics(r'''
void f() {
var x = 0;
var y = 1;
if (x > y)
print('');
else ;
print('');
}
''', [
lint(72, 1),
]);
}
test_else_noEmptyStatement_enclosed() async {
await assertNoDiagnostics(r'''
void f() {
var x = 0;
var y = 1;
if (x > y) {
print('');
} else {
print('');
}
}
''');
}
test_else_noEmptyStatement_notEnclosed() async {
await assertNoDiagnostics(r'''
void f() {
var x = 0;
var y = 1;
if (x > y)
print('');
else
print('');
}
''');
}
test_else_noStatement_notEnclosed() async {
await assertDiagnostics(r'''
void f() {
var x = 0;
var y = 1;
if (x > y)
print('');
else
}
''', [
// No lint
error(ParserErrorCode.EXPECTED_TOKEN, 67, 4),
error(ParserErrorCode.MISSING_IDENTIFIER, 72, 1),
]);
}
}