Jens Johansen
0329ebfd99
This CL primarily adds a lint for fields with `StackTrace.current` which is often useful for debugging, but shouldn't be left in. * Add an ast visitor after the "explicit creation test", finding - for now - `StackTrace.current` calls in fields. This should have caught the left-in debug such in https://dart-review.googlesource.com/c/sdk/+/379281. * Renamed explicit_creation to compile_and_lint * Remove (for some time) unused "smoke_test_quick" files. * Add kernel to the compile_and_lint suite, but ignore it for explicit creation (i.e. kernel will also be checked for fields with `StackTrace.current`). Change-Id: Ib886d23a8945e7063dc673a7f99cbb3a6adc1139 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382361 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
The frontend_server package is used by both the flutter command line tool and the frontend_server_client package (used by webdev and package:test).
API Stability
Changes to the command line API or behavior should be tested against the following test suites (in addition to normal HHH testing):
- flutter_tools: https://github.com/flutter/flutter/tree/master/packages/flutter_tools
- frontend_server_client: https://github.com/dart-lang/webdev/tree/master/frontend_server_client
Otherwise these changes will need to be carefully coordinated with the flutter tooling and frontend_server_client teams.
This API stability does not cover any of the source code APIs.
Stable subset
- The frontend_server kernel compilation and expression evaluation for kernel should be considered "stable".
- The frontend_server JavaScript compilation is semi-stable, but clients should anticipate coordinated breaking changes in the future.
- The frontend_server JavaScript expression evaluation is experimental and is expected to change significantly from Dec 2020 through the end of 2021.
- Specific flags may be added for experimentation and should not be considered stable.