Jens Johansen
d5b01a1960
[VM] Ignore dart scheme scripts in isolate reload
...
After cl/128585 landed a app-jit failure started throwing an error:
>testee>err> kernel-service: Error: Unhandled exception:
>testee>err> Bad state: No element
>testee>err> #0 Iterable.first (dart:core/iterable.dart:520:7)
>testee>err> #1 MappedIterable.first (dart:_internal/iterable.dart:374:31)
>testee>err> #2 lookupOrBuildNewIncrementalCompiler (file:///b/s/w/ir/cache/builder/sdk/pkg/vm/bin/kernel_service.dart:400:45)
>testee>err> #3 _processLoadRequest (file:///b/s/w/ir/cache/builder/sdk/pkg/vm/bin/kernel_service.dart:679:22)
>testee>err> #4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:174:12)
>testee>err>
This is caused by the change ultimately adding scripts for the used
mixed in files in "LoadedScripts".
In this case "dart:collection/map.dart" (as I recall) was added to it.
When reloading the source, it runs through all libraries that
"isn't dart scheme", and for all of those libraries through all scripts
reported by LoadedScripts for that library (now including something from
the platform), and checking if it has been modified. Checking if it is
modified only works for file:/// uris through, which platform files aren't,
so it just reports true (i.e. the file is modified).
This is then passed to the kernel service which - based on the list of
one file modified - somehow concludes that it has a compiler already
(which it doesn't) and then crashes.
This CL fixes this specific issue by also skipping scripts that are
"dart scheme".
There's still an underlying issue that has nothing to do with cl/128585
though. I'll comment on that in the bug
(https://github.com/dart-lang/sdk/issues/39869 ).
Bug: 39869
Change-Id: I1a3f2de888ec53c40f4b6b46a369595abae5bb44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130374
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-01-09 07:55:27 +00:00
..
2020-01-09 01:37:27 +00:00
2020-01-09 01:02:48 +00:00
2019-08-08 00:47:55 +00:00
2019-12-26 23:23:34 +00:00
2019-01-11 20:47:10 +00:00
2019-01-25 16:45:13 +00:00
2019-10-21 16:26:39 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 22:00:48 +00:00
2019-07-11 13:36:02 +00:00
2019-11-01 17:06:02 +00:00
2019-10-07 18:13:06 +00:00
2019-12-16 18:32:23 +00:00
2019-11-14 12:49:06 +00:00
2019-10-16 08:25:53 +00:00
2019-10-16 08:25:53 +00:00
2019-11-18 19:54:53 +00:00
2020-01-02 23:13:06 +00:00
2019-09-04 00:08:58 +00:00
2019-09-18 14:56:27 +00:00
2019-09-18 14:56:27 +00:00
2020-01-08 18:56:21 +00:00
2019-04-24 23:12:45 +00:00
2019-06-05 01:05:51 +00:00
2020-01-08 19:35:00 +00:00
2019-06-20 18:27:21 +00:00
2019-11-01 00:43:59 +00:00
2019-12-11 18:54:08 +00:00
2019-11-21 19:37:26 +00:00
2020-01-06 18:58:11 +00:00
2020-01-06 18:58:11 +00:00
2019-11-21 12:28:45 +00:00
2019-11-21 12:28:45 +00:00
2019-11-18 11:50:13 +00:00
2019-12-18 10:34:41 +00:00
2019-11-18 11:50:13 +00:00
2019-01-25 16:45:13 +00:00
2019-08-05 10:46:29 +00:00
2019-11-21 12:28:45 +00:00
2019-07-10 22:20:10 +00:00
2019-06-12 21:56:53 +00:00
2019-06-12 21:56:53 +00:00
2019-09-18 12:24:31 +00:00
2019-06-12 21:56:53 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-11-06 17:46:32 +00:00
2019-04-05 21:12:44 +00:00
2019-12-03 22:00:48 +00:00
2019-11-21 14:11:55 +00:00
2020-01-09 01:37:27 +00:00
2019-10-15 20:27:12 +00:00
2020-01-09 01:37:27 +00:00
2019-04-24 23:12:45 +00:00
2020-01-09 01:37:27 +00:00
2019-06-21 21:38:09 +00:00
2019-12-20 03:26:29 +00:00
2019-04-24 23:12:45 +00:00
2020-01-09 01:37:27 +00:00
2019-10-27 18:18:29 +00:00
2019-08-01 14:14:39 +00:00
2019-09-05 21:41:42 +00:00
2019-11-18 16:58:53 +00:00
2019-10-23 14:44:33 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-05 21:41:42 +00:00
2019-11-14 02:08:35 +00:00
2020-01-08 19:35:00 +00:00
2019-12-13 00:41:46 +00:00
2019-08-30 17:49:28 +00:00
2019-05-06 21:01:39 +00:00
2019-10-21 16:26:39 +00:00
2019-10-21 16:26:39 +00:00
2019-11-20 19:57:11 +00:00
2019-11-20 19:57:11 +00:00
2020-01-08 18:56:21 +00:00
2019-11-13 01:40:36 +00:00
2019-08-30 17:49:28 +00:00
2019-12-03 22:00:48 +00:00
2019-06-12 21:56:53 +00:00
2019-06-12 21:56:53 +00:00
2019-09-18 12:24:31 +00:00
2019-06-05 17:39:04 +00:00
2019-06-12 21:56:53 +00:00
2019-12-20 19:06:54 +00:00
2019-12-03 22:00:48 +00:00
2019-06-12 21:56:53 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-07-31 11:52:44 +00:00
2019-07-31 11:52:44 +00:00
2019-12-20 13:38:30 +00:00
2019-12-20 10:14:10 +00:00
2019-12-18 14:14:41 +00:00
2019-12-18 14:14:41 +00:00
2019-09-05 21:41:42 +00:00
2020-01-06 22:32:19 +00:00
2019-09-30 20:19:03 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2020-01-06 18:58:11 +00:00
2020-01-06 18:58:11 +00:00
2019-08-30 17:49:28 +00:00
2020-01-06 12:15:59 +00:00
2019-11-18 10:11:38 +00:00
2019-11-18 10:11:38 +00:00
2019-09-05 21:41:42 +00:00
2019-11-11 23:56:00 +00:00
2019-11-07 22:45:47 +00:00
2019-09-13 18:25:16 +00:00
2019-01-11 20:47:10 +00:00
2019-03-08 00:06:37 +00:00
2019-01-25 16:45:13 +00:00
2019-03-08 00:06:37 +00:00
2019-01-25 16:45:13 +00:00
2019-01-25 16:45:13 +00:00
2019-10-21 18:30:54 +00:00
2019-10-21 18:30:54 +00:00
2019-03-22 23:46:51 +00:00
2019-09-05 21:41:42 +00:00
2019-12-20 10:14:10 +00:00
2019-12-20 10:14:10 +00:00
2019-06-12 21:56:53 +00:00
2019-07-10 22:20:10 +00:00
2019-10-23 14:44:33 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-01-25 16:45:13 +00:00
2019-05-08 17:33:15 +00:00
2019-12-13 15:03:18 +00:00
2019-01-25 16:45:13 +00:00
2019-10-27 18:18:29 +00:00
2020-01-08 19:35:00 +00:00
2019-11-15 22:55:26 +00:00
2019-01-18 18:23:26 +00:00
2019-01-18 18:23:26 +00:00
2020-01-06 18:58:11 +00:00
2020-01-09 07:55:27 +00:00
2019-12-03 22:00:48 +00:00
2019-11-14 02:08:35 +00:00
2020-01-06 18:58:11 +00:00
2020-01-06 18:58:11 +00:00
2019-10-17 03:45:41 +00:00
2019-10-17 03:45:41 +00:00
2019-05-03 18:07:27 +00:00
2019-05-03 18:07:27 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 12:29:35 +00:00
2019-12-27 19:46:15 +00:00
2019-12-27 19:46:15 +00:00
2019-12-19 06:59:28 +00:00
2019-12-04 19:19:29 +00:00
2019-11-12 12:32:08 +00:00
2019-12-03 22:00:48 +00:00
2019-09-18 12:24:31 +00:00
2019-09-18 12:24:31 +00:00
2019-01-25 16:45:13 +00:00
2019-01-11 20:47:10 +00:00
2019-04-02 22:45:24 +00:00
2019-04-02 22:45:24 +00:00
2019-04-02 22:45:24 +00:00
2019-10-27 18:18:29 +00:00
2019-03-06 19:16:27 +00:00
2019-04-02 22:45:24 +00:00
2019-09-04 18:49:40 +00:00
2019-09-04 18:49:40 +00:00
2019-05-06 21:01:39 +00:00
2019-11-05 20:25:43 +00:00
2019-11-05 20:25:43 +00:00
2019-05-06 21:01:39 +00:00
2019-06-03 14:36:04 +00:00
2019-06-03 14:36:04 +00:00
2019-10-28 19:58:53 +00:00
2019-04-02 11:49:18 +00:00
2019-10-28 19:58:53 +00:00
2019-12-27 21:27:35 +00:00
2019-11-18 19:54:53 +00:00
2019-11-18 19:54:53 +00:00
2019-11-18 19:54:53 +00:00
2019-01-25 16:45:13 +00:00
2019-05-06 21:01:39 +00:00
2019-05-06 21:01:39 +00:00
2019-04-24 19:53:35 +00:00
2019-06-05 21:54:11 +00:00
2019-04-24 19:53:35 +00:00
2019-04-24 19:53:35 +00:00
2019-04-24 19:53:35 +00:00
2019-04-24 19:53:35 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-08-19 19:31:42 +00:00
2020-01-08 03:22:59 +00:00
2020-01-08 03:22:59 +00:00
2019-07-10 22:20:10 +00:00
2019-11-14 02:08:35 +00:00
2020-01-08 19:35:00 +00:00
2020-01-08 19:35:00 +00:00
2019-09-06 23:37:33 +00:00
2019-12-19 15:09:32 +00:00
2019-12-11 10:00:29 +00:00
2019-07-10 22:20:10 +00:00
2020-01-08 19:35:00 +00:00
2020-01-08 19:35:00 +00:00
2019-10-27 18:18:29 +00:00
2019-10-31 21:34:49 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-10-17 21:45:38 +00:00
2019-12-06 19:46:31 +00:00
2019-10-02 05:33:29 +00:00
2019-12-06 19:46:31 +00:00
2019-05-23 17:42:37 +00:00
2019-02-26 01:00:26 +00:00
2019-10-25 19:21:56 +00:00
2019-10-25 19:21:56 +00:00
2019-10-27 18:18:29 +00:00
2019-10-17 21:45:38 +00:00
2019-12-04 19:19:29 +00:00
2019-09-06 23:37:33 +00:00
2019-10-17 21:45:38 +00:00
2019-05-06 21:01:39 +00:00
2019-06-26 00:17:04 +00:00
2019-05-06 21:01:39 +00:00
2019-09-05 21:41:42 +00:00
2019-12-11 18:15:27 +00:00
2019-12-11 18:15:27 +00:00
2019-11-01 19:08:42 +00:00
2019-11-11 23:56:00 +00:00
2019-12-07 00:28:15 +00:00
2019-12-19 06:59:28 +00:00
2019-11-14 12:49:06 +00:00
2020-01-06 18:58:11 +00:00
2019-08-19 19:31:42 +00:00
2019-11-06 22:44:33 +00:00
2019-12-16 18:32:23 +00:00
2020-01-06 18:58:11 +00:00
2019-12-13 00:41:46 +00:00
2019-04-29 09:11:48 +00:00
2020-01-09 01:37:27 +00:00
2020-01-09 01:37:27 +00:00
2019-04-29 09:11:48 +00:00
2019-04-29 09:11:48 +00:00
2019-03-14 14:26:47 +00:00
2019-09-05 21:41:42 +00:00
2019-04-29 09:11:48 +00:00
2019-04-30 16:17:18 +00:00
2019-04-30 16:17:18 +00:00
2019-10-17 16:51:32 +00:00
2019-04-29 09:11:48 +00:00
2019-08-20 00:49:52 +00:00
2019-09-05 21:41:42 +00:00
2019-04-29 09:11:48 +00:00
2020-01-08 19:35:00 +00:00
2019-04-11 09:57:25 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2020-01-06 22:32:19 +00:00
2019-07-10 22:20:10 +00:00
2020-01-08 19:35:00 +00:00
2019-10-30 21:55:25 +00:00
2019-09-05 21:41:42 +00:00
2019-12-06 19:54:42 +00:00
2019-12-06 19:54:42 +00:00
2019-09-25 21:41:55 +00:00
2019-07-23 15:24:28 +00:00
2019-12-27 19:46:15 +00:00
2019-12-27 21:27:35 +00:00
2019-09-07 01:04:08 +00:00
2019-12-03 22:00:48 +00:00
2019-11-16 00:22:56 +00:00
2019-07-16 19:46:56 +00:00
2019-07-16 19:46:56 +00:00
2019-07-16 19:46:56 +00:00
2019-10-21 16:26:39 +00:00
2019-10-15 08:50:52 +00:00
2019-10-23 14:44:33 +00:00
2019-10-02 20:37:10 +00:00
2019-10-27 18:18:29 +00:00
2019-11-01 00:43:59 +00:00
2019-10-09 23:38:30 +00:00
2019-11-01 00:43:59 +00:00
2019-10-17 21:45:38 +00:00
2019-08-01 21:07:50 +00:00
2019-10-27 18:18:29 +00:00
2019-03-07 02:04:41 +00:00
2019-04-29 09:11:48 +00:00
2019-10-02 05:33:29 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-12-11 10:00:29 +00:00
2019-12-20 19:06:54 +00:00
2019-12-20 19:06:54 +00:00
2019-12-20 19:06:54 +00:00
2019-09-05 21:41:42 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-12-19 15:09:32 +00:00
2019-07-10 22:20:10 +00:00
2019-11-14 19:11:38 +00:00
2019-12-20 03:26:29 +00:00
2019-11-15 00:15:32 +00:00
2019-12-19 15:09:32 +00:00
2019-01-11 20:47:10 +00:00
2019-01-11 20:47:10 +00:00
2019-06-18 17:51:10 +00:00
2019-01-15 22:07:51 +00:00
2019-01-11 20:47:10 +00:00
2019-04-16 20:56:39 +00:00
2019-06-18 17:51:10 +00:00
2019-12-04 14:26:48 +00:00
2019-06-18 17:51:10 +00:00
2019-07-23 10:58:11 +00:00
2019-07-23 10:58:11 +00:00
2019-01-11 20:47:10 +00:00
2019-01-11 20:47:10 +00:00
2019-01-25 16:45:13 +00:00
2019-01-25 16:45:13 +00:00
2019-10-21 16:26:39 +00:00
2019-12-27 19:46:15 +00:00
2020-01-06 18:58:11 +00:00
2019-12-11 19:36:18 +00:00
2019-10-18 01:33:03 +00:00
2019-03-13 23:44:11 +00:00
2019-12-07 00:28:15 +00:00
2020-01-02 23:13:06 +00:00
2020-01-02 23:13:06 +00:00
2019-10-09 21:48:20 +00:00
2019-09-05 10:36:13 +00:00
2019-10-29 23:39:36 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2020-01-08 19:35:00 +00:00
2019-10-27 18:18:29 +00:00
2019-04-22 20:15:43 +00:00
2019-04-22 20:15:43 +00:00
2019-04-22 20:15:43 +00:00
2019-12-11 10:00:29 +00:00
2019-12-11 18:15:27 +00:00
2019-01-11 20:47:10 +00:00
2019-10-17 17:19:32 +00:00
2019-06-17 13:09:50 +00:00
2019-06-17 13:09:50 +00:00
2019-03-15 22:35:25 +00:00
2019-03-15 22:35:25 +00:00
2019-09-24 15:03:19 +00:00
2019-12-18 18:02:41 +00:00
2019-12-18 18:02:41 +00:00
2019-09-24 15:03:19 +00:00
2019-03-12 20:45:45 +00:00
2019-12-10 12:26:05 +00:00
2019-07-30 23:26:28 +00:00
2020-01-06 18:58:11 +00:00
2019-05-01 00:36:14 +00:00
2019-03-05 22:32:22 +00:00
2019-10-17 16:51:32 +00:00
2019-10-17 16:51:32 +00:00