Nate Bosch
d3c0d59706
Towards #40434 Towards #38875 Fixes #33834 - Add a shared error message for a non-external constructor. - Check for non-external non-factory constructors constructors in the JS interop checks. - Remove commented out code in Dart2JS that used to handle this check. - Clean up skipped tests due to the missing static error. The status in `legacy_status_dart2js.csv` has no behavior impact but is removed for completeness. - Add `external` to a few test cases. - Remove unused dart2js error message. - Add `annotating` to hardcoded spelling list. - Ignore missing example for web specific error message. - Switch some dart2js error expectations to GENERIC since the message is no longer defined with other dart2js errors. Non-external synthetic constructors are ignored for now. An upcoming change will automatically convert these to external. Change-Id: I3b4a042392826c528689d81c4255f5369a0a7a90 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138043 Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
Shared kernel visitors checking for incorrect usage of @JS() style interop.