Ben Konyi
a16a6537e5
This reverts commit3370a4e393. Reason for revert: Fixes landed in google3 (cl/650630536). Original change's description: > Revert "Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer"" > > This reverts commit44d4451476. > > Reason for revert: b/350443042 > > Original change's description: > > Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer" > > > > In the previous version of this change, if the user had 'dart' on their > > PATH and invoked 'dart compile js' (which spawns the VM service after > > compilation completes), the VM service would attempt to spawn DDS using > > './dart' as the executable path instead of 'dart'. This would result in > > DDS failing to start, causing the VM to print an error and hang. > > > > This updated change checks to see if the parent directory of > > `Platform.executable` is '.' and then verifies if './dart' exists or > > not. If it doesn't, 'dart' is likely on the user's PATH and should be > > used directly as the executable path. > > > > See https://github.com/dart-lang/sdk/issues/56087 for details. > > > > This reverts commit4b88698e48. > > > > TEST=pkg/dds/test/control_web_server_starts_dds_with_dart_on_path_test.dart > > > > Change-Id: Id0f1dadd01d9202cbf7717f31393b43171cf3968 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373561 > > Auto-Submit: Ben Konyi <bkonyi@google.com> > > Reviewed-by: Derek Xu <derekx@google.com> > > Commit-Queue: Ben Konyi <bkonyi@google.com> > > Change-Id: I424c4b91b0b108ae4c9dffa0059ed90c918897e3 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373744 > Reviewed-by: Siva Annamalai <asiva@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Srujan Gaddam <srujzs@google.com> > Commit-Queue: Siva Annamalai <asiva@google.com> > Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com> Change-Id: Id7ddff5a80399203fb8058d84bc89fda2073da95 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375000 Auto-Submit: Ben Konyi <bkonyi@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com> Commit-Queue: Derek Xu <derekx@google.com> Reviewed-by: Derek Xu <derekx@google.com>