Daco Harkes
f53af0d445
The compounds transformation converting fields into getters and setters now retains the annotations on the getters so that they can be read during recompilation. This splits up `_replaceFields` into `_findFields` and `_replaceFields`. `_findFields` works for both transformed and non-transformed compounds. This splits up `_compoundClassDependencies` out from `_checkFieldAnnotations`. The former is run on all compounds transitively reached from the compounds being compiled, the latter only on the compounds being (re)compiled. `manualVisitInTopologicalOrder` now visits compounds from all libraries, not just the ones in the libraries being (re)compiled. It is responsible for filling the `compoundCache` in topological order. And, this CL introduces the `InvalidNativeTypeCfe` to support processing compounds with invalid fields, which might be nested later in other compounds. Bug: https://github.com/dart-lang/sdk/issues/45899 TEST=pkg/front_end/testcases/incremental/crash_05.yaml TEST=tests/ffi(_2)/* Change-Id: I07a2214fd460f4d5e6a84df81e8b140dd80401dc Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try Fixed: 45899 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198281 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Jens Johansen <jensj@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency