Vyacheslav Egorov
65f4a733bb
After this change we no longer push outgoing arguments for normal Dart calls, but instead simply move them into an area reserved for outgoing arguments at the top of the frame. This allows us to stop mutating SP and avoid explicit Drop(argc) after each call. There are still other places in the generated code where we push something onto the stack either to free a temporary register or spill a value across a slow-path call. This is the first step towards switching to native SP on ARM64. # Code Size Impact I have tested this on a large internal application and got the following size delta ## ARM | | Before | After | Delta | | |--------|----------|----------|---------|-------| | ROData | 6366632 | 6463680 | +97048 | +1.5% | | Code | 22714192 | 22043984 | -670208 | -2.9% | | Total | 33723701 | 33150477 | -573224 | -1.6% | ## ARM64 | | Before | After | Delta | | |--------|----------|----------|---------|-------| | ROData | 7122032 | 7214288 | +92256 | +1.3% | | Code | 21607196 | 20741788 | -865408 | -4.0% | | Total | 33375769 | 32602544 | -773225 | -2.3% | TEST=ci Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-product-x64-try,vm-precomp-ffi-qemu-linux-release-riscv64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-simarm64-try Bug: https://github.com/dart-lang/sdk/issues/39083 Change-Id: Icace0c986285b9c16e41786cded44f88277bd25f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282029 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
Dart VM Compilation Pipeline
This folder contains Dart VM compilation pipeline.
Compilation pipeline is mainly responsible for converting AST or Kernel AST into IL flow graphs and then generating native code from IL.
It has the following structure:
| Directory | What goes there |
|---|---|
assembler/ |
Assemblers and disassemblers |
backend/ |
IL based compilation backend: optimization passes and architecture specific code generation rules |
frontend/ |
Frontends responsible for converting AST into IL |
jit/ |
JIT specific passes and compilation pipeline entry points |
aot/ |
AOT specific passes and compilation pipeline entry points |
. |
Shared code or code without clear designation. |
Currently there are no layering restrictions and components from different subfolders can reference each other.