Danny Tuppeny
63772f10fe
The stream created by memory resources was a single-subscriber stream. The stream from the physical file system watchers was a broadcast stream, but the code to translate FileSystemException to the abstractions was written in a way that made it single-subscriber. This fixes both to ensure that a `ResourceWatcher` can support multiple subscribers that can subscribe and cancel at different times. We don't currently use this, so this change should effectively be a no-op right now, but it will allow us to reuse the temporary catchers we create when set up analysis roots instead of creating new ones. There's an issue at https://github.com/dart-lang/sdk/issues/54274 discussing changing how we watch here, but it may still be worth picking the low-hanging fruit in the short-term. Change-Id: I3bda77ddaee676c573021aa671cb01bae48bd56f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341740 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>