Stephen Adams
62a67ba5bc
The main reason is to do this change is to avoid inconsistencies in what is considered to be a `JSArray`. Using `Array.isArray` allows js-interop where the JavaScript code subclasses `Array`. dart2js-production results: ArrayLoop.pseudopoly.hoisted1-indexing -50.20% ArrayLoop.pseudopoly.indexing -35.18% Iteration.concat.manual 11.69% ListCopy.List.int.unmodifiable.2 12.03% ListCopy.for.int.2 12.58% ListCopy.spread.int.2 13.57% ListCopy.toList.fixed.100 16.06% ListCopy.List.of.fixed.100 16.96% ListCopy.toList.100 17.28% ListCopy.spread.int.cast.2 18.45% ObjectHash.hash.5 19.62% TypedDataPoly.A_UVx5.view.2 21.12% ObjectHash.manual.5 21.70% ListCopy.spread.int.map.2 21.96% ListCopy.spread.int.cast.100 22.12% TypedDataPoly.A_UVx5.view.100 23.04% ListCopy.spread.int.map.100 25.26% ListCopy.List.of.100 27.88% ImagingGaussianBlurOnce 29.67% MegaEquality 37.90% An investigation of the two regressions shows that they benefit from a micro-benchmarking effect. The previous code was monomorphic at the property access in `receiver.constructor == Array`. If this is forced to be polymorphic, the baseline is quite a bit worse, leading to an improvement in line with some of the other benchmarks. Change-Id: I5c265b1d7408fbd41da9c6fa17472bf648000c8d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287140 Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Stephen Adams <sra@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency