Alexander Markov
6239c434fb
Elimination of redundant type cast 'x as Function' where x is a function type (such as 'void Function(int)') is not correct because it changes semantics of a function call if such expression is used as a receiver. "Function" static type of receiver allows arbitrary function calls, while known function type of the receiver means the call doesn't need to check parameter types. Static type of receiver is currently not stored in kernel AST but calculated from the receiver node, so replacing 'x as Function' with 'x' changes static type of the receiver from "Function" to function type. TEST=tests/language/regress/regress45428_test.dart Fixes https://github.com/dart-lang/sdk/issues/45428 Change-Id: If7148450526703daa63a442adf67a9e7a2dcea54 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193524 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency