Nate Biggs
600f8a9601
This issue was partially fixed by: https://dart-review.googlesource.com/c/sdk/+/428541 However, this only looked at the case of a member in an abstract class that itself was made abstract if it was unused. TFA does not make the member abstract if the enclosing class is not abstract: pkg/vm/lib/transformations/type_flow/transformer.dart#L2289 Instead we can use the unreachable metadata to identify these unreachable body members (that have default values cleared): pkg/vm/lib/transformations/type_flow/transformer.dart#L736 Attached test fails prior to this fix. Bug: https://github.com/dart-lang/sdk/issues/62273 Change-Id: I1ccb818ec41bbe805ee828be0b96ba23e73beae4 Tested: Introduced unit test. Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469280 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Nate Biggs <natebiggs@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.