Paul Berry
5fc5f3678a
This change reworks `MemberDuplicateDefinitionVerifier._checkConflictingConstructorAndStatic` and `MemberDuplicateDefinitionVerifier._checkDuplicateIdentifier` into a form that is easier to reason about and has slightly faster performance (measured by instruction count). In the previous design, two maps were maintained for each scope in which getters and setters might appear: - one called `getterScope`, which (confusingly) held getters, setters, and method declarations, - and one called `setterScope` which only held setters. This was difficult to reason about. In particular, it had a longstanding bug that was only recently fixed (see https://dart-review.googlesource.com/c/sdk/+/434061): if a setter was encountered first, it was stored in `getterScope`, but if a getter was encountered next, it was necessary to move the setter to `setterScope` in order to store the getter in `getterScope`. It was also inefficient, since in many cases, two map lookups were needed in order to check for both getter and setter conflicts. In the new design, there is a single map, whose values point to either a `_ScopeEntryFragment` (in the case where just one declaration of the given name has been seen) or a `_ScopeEntryGetterSetterPair` (in the case where both a getter and a setter have been seen). The new design has modestly better performance when measured by front_end/tool/benchmarker.dart: Comparing snapshot #1 (before.aot) with snapshot #2 (after.aot) instructions:u: -0.0192% +/- 0.0131% (-6291379.67 +/- 4292101.91) (32692292436.33 -> 32686001056.67) Change-Id: Ia6675fa4d3579779e6066db3760d2cc38a2c859e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435602 Reviewed-by: Jens Johansen <jensj@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.