d579b03f71
Changes the `front_end` and `_fe_analyzer_shared` code that reports the following diagnostics so that it uses `withArguments` rather than `withArgumentsOld`: - `expectedButGot` - `expectedButGot2` - `expectedAfterButGot` - `expectedToken` - `unmatchedToken` - `constFieldWithoutInitializer` - `finalFieldWithoutInitializer` - `superclassHasNoMethod` - `unavailableDartLibrary` - `unsupportedPlatformDartLibraryImport` These messages required special care because they are translated into analyzer diagnostics by the analyzer method `FastaErrorReporter.reportByCode`, and the logic to do the translation depends on the exact parameter names used by the messages. For some of the messages I've clarified the parameter names and updated `FastaErrorReporter.reportByCode` accordingly. For others, I left the parameter names as is. Change-Id: I6a6a696481c75f4cbb198d1e012aa1ca4294ed61 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476323 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
153 lines
6.0 KiB
Plaintext
153 lines
6.0 KiB
Plaintext
Problems reported:
|
|
|
|
parser/coverage/string2:2:22: Expected ';' after this.
|
|
return """æbler$bar"""
|
|
^^^
|
|
|
|
parser/coverage/string2:6:10: Expected ';' after this.
|
|
return """æbler"""
|
|
^^^^^^^^^^^
|
|
|
|
parser/coverage/string2:10:10: Expected ';' after this.
|
|
return r"""hello"""
|
|
^^^^^^^^^^^^
|
|
|
|
parser/coverage/string2:14:10: Expected ';' after this.
|
|
return """
|
|
^^^^...
|
|
|
|
parser/coverage/string2:21:10: Expected ';' after this.
|
|
return """æbler\
|
|
^^^^^^^^^
|
|
|
|
parser/coverage/string2:21:10: String starting with """ must end with """.
|
|
return """æbler\
|
|
^^^^^^^^^
|
|
|
|
parser/coverage/string2:19:13: Can't find '}' to match '{'.
|
|
void quux() {
|
|
^
|
|
|
|
beginCompilationUnit(void)
|
|
beginMetadataStar(void)
|
|
endMetadataStar(0)
|
|
beginTopLevelMember(void)
|
|
beginTopLevelMethod(UnmatchedToken({), null, null)
|
|
handleVoidKeyword(void)
|
|
handleIdentifier(foo, topLevelFunctionDeclaration)
|
|
handleNoTypeVariables(()
|
|
beginFormalParameters((, MemberKind.TopLevelMethod)
|
|
beginMetadataStar(dynamic)
|
|
endMetadataStar(0)
|
|
beginFormalParameter(dynamic, MemberKind.TopLevelMethod, null, null, null)
|
|
handleIdentifier(dynamic, typeReference)
|
|
handleNoTypeArguments(bar)
|
|
handleType(dynamic, null)
|
|
handleIdentifier(bar, formalParameterDeclaration)
|
|
handleFormalParameterWithoutValue())
|
|
endFormalParameter(null, null, null, null, bar, null, null, FormalParameterKind.requiredPositional, MemberKind.TopLevelMethod)
|
|
endFormalParameters(1, (, ), MemberKind.TopLevelMethod)
|
|
handleAsyncModifier(null, null)
|
|
beginBlockFunctionBody({)
|
|
beginReturnStatement(return)
|
|
beginLiteralString("""æbler)
|
|
handleIdentifier(bar, expression)
|
|
handleNoTypeArguments(""")
|
|
handleNoArguments(""")
|
|
handleSend(bar, bar)
|
|
handleInterpolationExpression($, null)
|
|
handleStringPart(""")
|
|
endLiteralString(1, })
|
|
handleRecoverableError(Message[Template(ExpectedAfterButGot), Expected ';' after this., null, {expected: ;}], """, """)
|
|
endReturnStatement(true, return, ;)
|
|
endBlockFunctionBody(1, {, })
|
|
endTopLevelMethod(void, null, })
|
|
endTopLevelDeclaration(})
|
|
beginMetadataStar(void)
|
|
endMetadataStar(0)
|
|
beginTopLevelMember(void)
|
|
beginTopLevelMethod(}, null, null)
|
|
handleVoidKeyword(void)
|
|
handleIdentifier(bar, topLevelFunctionDeclaration)
|
|
handleNoTypeVariables(()
|
|
beginFormalParameters((, MemberKind.TopLevelMethod)
|
|
endFormalParameters(0, (, ), MemberKind.TopLevelMethod)
|
|
handleAsyncModifier(null, null)
|
|
beginBlockFunctionBody({)
|
|
beginReturnStatement(return)
|
|
beginLiteralString("""æbler""")
|
|
endLiteralString(0, })
|
|
handleRecoverableError(Message[Template(ExpectedAfterButGot), Expected ';' after this., null, {expected: ;}], """æbler""", """æbler""")
|
|
endReturnStatement(true, return, ;)
|
|
endBlockFunctionBody(1, {, })
|
|
endTopLevelMethod(void, null, })
|
|
endTopLevelDeclaration(})
|
|
beginMetadataStar(void)
|
|
endMetadataStar(0)
|
|
beginTopLevelMember(void)
|
|
beginTopLevelMethod(}, null, null)
|
|
handleVoidKeyword(void)
|
|
handleIdentifier(baz, topLevelFunctionDeclaration)
|
|
handleNoTypeVariables(()
|
|
beginFormalParameters((, MemberKind.TopLevelMethod)
|
|
endFormalParameters(0, (, ), MemberKind.TopLevelMethod)
|
|
handleAsyncModifier(null, null)
|
|
beginBlockFunctionBody({)
|
|
beginReturnStatement(return)
|
|
beginLiteralString(r"""hello""")
|
|
endLiteralString(0, })
|
|
handleRecoverableError(Message[Template(ExpectedAfterButGot), Expected ';' after this., null, {expected: ;}], r"""hello""", r"""hello""")
|
|
endReturnStatement(true, return, ;)
|
|
endBlockFunctionBody(1, {, })
|
|
endTopLevelMethod(void, null, })
|
|
endTopLevelDeclaration(})
|
|
beginMetadataStar(void)
|
|
endMetadataStar(0)
|
|
beginTopLevelMember(void)
|
|
beginTopLevelMethod(}, null, null)
|
|
handleVoidKeyword(void)
|
|
handleIdentifier(qux, topLevelFunctionDeclaration)
|
|
handleNoTypeVariables(()
|
|
beginFormalParameters((, MemberKind.TopLevelMethod)
|
|
endFormalParameters(0, (, ), MemberKind.TopLevelMethod)
|
|
handleAsyncModifier(null, null)
|
|
beginBlockFunctionBody({)
|
|
beginReturnStatement(return)
|
|
beginLiteralString("""
|
|
æbler
|
|
""")
|
|
endLiteralString(0, })
|
|
handleRecoverableError(Message[Template(ExpectedAfterButGot), Expected ';' after this., null, {expected: ;}], """
|
|
æbler
|
|
""", """
|
|
æbler
|
|
""")
|
|
endReturnStatement(true, return, ;)
|
|
endBlockFunctionBody(1, {, })
|
|
endTopLevelMethod(void, null, })
|
|
endTopLevelDeclaration(})
|
|
beginMetadataStar(void)
|
|
endMetadataStar(0)
|
|
beginTopLevelMember(void)
|
|
beginTopLevelMethod(}, null, null)
|
|
handleVoidKeyword(void)
|
|
handleIdentifier(quux, topLevelFunctionDeclaration)
|
|
handleNoTypeVariables(()
|
|
beginFormalParameters((, MemberKind.TopLevelMethod)
|
|
endFormalParameters(0, (, ), MemberKind.TopLevelMethod)
|
|
handleAsyncModifier(null, null)
|
|
beginBlockFunctionBody({)
|
|
beginReturnStatement(return)
|
|
beginLiteralString("""æbler\""")
|
|
endLiteralString(0, })
|
|
handleRecoverableError(Message[Template(ExpectedAfterButGot), Expected ';' after this., null, {expected: ;}], """æbler\""", """æbler\""")
|
|
endReturnStatement(true, return, ;)
|
|
endBlockFunctionBody(1, {, })
|
|
endTopLevelMethod(void, null, })
|
|
endTopLevelDeclaration(})
|
|
handleErrorToken(UnterminatedString("""))
|
|
handleRecoverableError(Message[Template(UnterminatedString), String starting with """ must end with """., null, {openQuote: """, expectedCloseQuote: """}], UnterminatedString("""), UnterminatedString("""))
|
|
handleErrorToken(UnmatchedToken({))
|
|
handleRecoverableError(Message[Template(UnmatchedToken), Can't find '}' to match '{'., null, {expected: }, lexeme: {}], UnmatchedToken({), UnmatchedToken({))
|
|
endCompilationUnit(5, )
|