Liam Appelbe
011068f824
Every known user of the coverage report just wants the line numbers. At the moment they have to do a second RPC to get the Script object, so they can translate the token positions into line numbers. Slower test times with coverage are usually caused by the extra time it takes to run the RPCs. So reporting the line number directly will halve the time it takes to get coverage, for most users. Bug: https://github.com/flutter/flutter/issues/86722 Change-Id: I7b8d436669713ebc7b7096790a02593b9cb94dda TEST=CI Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211081 Commit-Queue: Liam Appelbe <liama@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
131 lines
3.1 KiB
Dart
131 lines
3.1 KiB
Dart
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:developer';
|
|
import 'package:test/test.dart';
|
|
import 'package:vm_service/vm_service.dart';
|
|
import 'common/service_test_common.dart';
|
|
import 'common/test_helper.dart';
|
|
|
|
String leafFunction() {
|
|
return "some constant";
|
|
}
|
|
|
|
void testFunction() {
|
|
debugger();
|
|
leafFunction();
|
|
debugger();
|
|
}
|
|
|
|
bool allRangesCompiled(coverage) {
|
|
for (int i = 0; i < coverage['ranges'].length; i++) {
|
|
if (!coverage['ranges'][i]['compiled']) {
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
IsolateTest coverageTest(Map<String, dynamic> expectedRange,
|
|
{required bool reportLines}) {
|
|
return (VmService service, IsolateRef isolateRef) async {
|
|
final isolateId = isolateRef.id!;
|
|
final isolate = await service.getIsolate(isolateId);
|
|
final stack = await service.getStack(isolateId);
|
|
|
|
// Make sure we are in the right place.
|
|
expect(stack.frames!.length, greaterThanOrEqualTo(1));
|
|
expect(stack.frames![0].function!.name, 'testFunction');
|
|
|
|
final Library root =
|
|
await service.getObject(isolateId, isolate.rootLib!.id!) as Library;
|
|
FuncRef funcRef =
|
|
root.functions!.singleWhere((f) => f.name == 'leafFunction');
|
|
Func func = await service.getObject(isolateId, funcRef.id!) as Func;
|
|
final location = func.location!;
|
|
|
|
final report = await service.getSourceReport(
|
|
isolateId,
|
|
[SourceReportKind.kCoverage],
|
|
scriptId: location.script!.id,
|
|
tokenPos: location.tokenPos,
|
|
endTokenPos: location.endTokenPos,
|
|
forceCompile: true,
|
|
reportLines: reportLines,
|
|
);
|
|
expect(report.ranges!.length, 1);
|
|
expect(report.ranges![0].toJson(), expectedRange);
|
|
expect(report.scripts!.length, 1);
|
|
expect(
|
|
report.scripts![0].uri,
|
|
endsWith('coverage_leaf_function_test.dart'),
|
|
);
|
|
};
|
|
}
|
|
|
|
var tests = <IsolateTest>[
|
|
hasStoppedAtBreakpoint,
|
|
coverageTest(
|
|
{
|
|
'scriptIndex': 0,
|
|
'startPos': 397,
|
|
'endPos': 447,
|
|
'compiled': true,
|
|
'coverage': {
|
|
'hits': [],
|
|
'misses': [397]
|
|
}
|
|
},
|
|
reportLines: false,
|
|
),
|
|
coverageTest(
|
|
{
|
|
'scriptIndex': 0,
|
|
'startPos': 397,
|
|
'endPos': 447,
|
|
'compiled': true,
|
|
'coverage': {
|
|
'hits': [],
|
|
'misses': [11]
|
|
}
|
|
},
|
|
reportLines: true,
|
|
),
|
|
resumeIsolate,
|
|
hasStoppedAtBreakpoint,
|
|
coverageTest(
|
|
{
|
|
'scriptIndex': 0,
|
|
'startPos': 397,
|
|
'endPos': 447,
|
|
'compiled': true,
|
|
'coverage': {
|
|
'hits': [397],
|
|
'misses': []
|
|
}
|
|
},
|
|
reportLines: false,
|
|
),
|
|
coverageTest(
|
|
{
|
|
'scriptIndex': 0,
|
|
'startPos': 397,
|
|
'endPos': 447,
|
|
'compiled': true,
|
|
'coverage': {
|
|
'hits': [11],
|
|
'misses': []
|
|
}
|
|
},
|
|
reportLines: true,
|
|
),
|
|
];
|
|
|
|
main([args = const <String>[]]) => runIsolateTests(
|
|
args,
|
|
tests,
|
|
'coverage_leaf_function_test.dart',
|
|
testeeConcurrent: testFunction,
|
|
);
|