Vyacheslav Egorov 4b5c267dbd
[vm/compiler] Support frameless functions ...
This CL allows register allocator to mark functions as frameless
in AOT bare instructions mode if they don't contain calls (with an
exception for write barrier related calls), don't require
spills and don't use optional or named parameters.
Calls to Write Barrier helper stubs introduce some complexity
on ARM/ARM64, where we need to take into account that return
address needs to be explicitly spilled from LR register. To keep
the code size balance (frame setup vs manual LR spilling on WB
slow path) we allow one instruction with a write barrier
per frameless function.
Flutter Gallery snapshot becomes 800KB smaller (3% reduction), but
APK size for some reason increases by .1%. On a large internal
application effect is much smaller (60K - 0.16% reduction).
Flutter Gallery is disproportionally affected by the change due to
abnormal amount of small getters originating from localizations:
each localized phrase becomes a getter returning a constant on a
localization specific class.
TEST=tested through normal test suite
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-ffi-android-release-arm64-try,vm-ffi-android-release-arm-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-android-release-arm64-try
Change-Id: I86cb45a57567ee654ead388957ac4e561634ef9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175304
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-12-10 15:51:27 +00:00
2020-12-10 15:51:27 +00:00
2020-12-09 09:39:59 +00:00
2020-11-03 21:39:37 +00:00
2020-11-13 19:07:20 +00:00
2020-11-13 22:10:54 +00:00
2020-12-01 07:27:14 +00:00
2020-11-13 22:10:54 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2020-11-13 20:40:24 +00:00
2020-12-04 22:25:12 +00:00
2020-10-22 13:08:10 +00:00
2020-10-06 17:10:05 +00:00
2020-05-26 08:47:30 +00:00
2020-12-04 22:46:12 +00:00
2020-12-07 19:43:48 +00:00
2020-12-07 19:43:48 +00:00
2020-10-22 13:08:10 +00:00
2020-12-07 20:05:38 +00:00
2020-10-21 19:36:56 +00:00
2020-11-19 13:29:09 +00:00
2020-07-09 18:33:32 +00:00
2020-11-13 22:10:54 +00:00
2020-12-07 19:43:48 +00:00
2020-11-24 11:25:58 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2020-10-09 10:08:16 +00:00
2020-11-13 22:10:54 +00:00
2020-12-10 15:51:27 +00:00
2020-12-10 15:51:27 +00:00
2020-12-10 15:51:27 +00:00
2020-08-12 17:23:14 +00:00
2020-10-28 17:42:35 +00:00
2020-12-01 07:27:14 +00:00
2020-09-23 21:05:59 +00:00
2020-10-28 17:42:35 +00:00
2020-12-10 15:51:27 +00:00
2020-12-10 15:51:27 +00:00
2020-12-10 12:15:17 +00:00
2020-06-01 23:21:38 +00:00
2020-12-10 12:15:17 +00:00
2020-06-11 12:29:19 +00:00
2020-11-27 09:11:49 +00:00
2020-11-30 16:04:12 +00:00
2020-06-26 09:39:15 +00:00
2020-06-25 03:36:41 +00:00
2020-06-25 03:36:41 +00:00
2020-06-25 03:36:41 +00:00
2020-12-01 08:28:24 +00:00
2020-12-09 09:39:59 +00:00
2020-12-10 12:15:17 +00:00
2020-12-02 21:08:58 +00:00
2020-11-03 10:27:44 +00:00
2020-12-01 16:01:15 +00:00
2020-10-29 02:52:03 +00:00
2020-12-09 09:39:59 +00:00
2020-09-17 06:07:50 +00:00
2020-10-12 11:07:21 +00:00
2020-10-06 07:59:33 +00:00
2020-10-09 10:08:16 +00:00
2020-07-09 14:55:11 +00:00
2020-12-03 12:40:28 +00:00
2020-12-01 07:27:14 +00:00
2020-10-16 20:05:02 +00:00
2020-10-16 20:05:02 +00:00
2020-10-28 17:42:35 +00:00
2020-11-13 19:07:20 +00:00
2020-10-06 17:10:05 +00:00
2020-10-06 17:10:05 +00:00
2020-11-16 23:52:40 +00:00
2020-10-06 17:10:05 +00:00
2020-06-02 21:29:03 +00:00
2020-12-03 02:29:38 +00:00
2020-12-03 02:29:38 +00:00
2020-11-13 00:29:38 +00:00
2020-11-13 00:29:38 +00:00
2020-12-10 12:15:17 +00:00
2020-12-09 09:39:59 +00:00
2020-12-09 09:39:59 +00:00
2020-11-03 10:27:44 +00:00
2020-12-01 07:27:14 +00:00
2020-11-26 15:08:35 +00:00
2020-10-28 17:42:35 +00:00
2020-05-20 14:05:40 +00:00
2020-09-18 09:35:22 +00:00
2020-05-26 22:40:52 +00:00
2020-11-13 19:07:20 +00:00
2020-11-03 10:27:44 +00:00
2020-11-13 19:07:20 +00:00
2020-11-13 19:07:20 +00:00
2020-07-17 19:29:47 +00:00
2020-12-10 15:51:27 +00:00
2020-11-02 21:11:50 +00:00
2020-12-10 15:51:27 +00:00
2020-12-10 15:51:27 +00:00
2020-12-10 15:51:27 +00:00
2020-12-10 15:51:27 +00:00
2020-11-06 20:05:53 +00:00
2020-12-07 19:43:48 +00:00
2020-10-28 17:42:35 +00:00
2020-05-26 22:40:52 +00:00
2020-12-09 17:36:20 +00:00
2020-12-09 09:39:59 +00:00
2020-12-08 00:36:38 +00:00
2020-12-08 00:36:38 +00:00
2020-08-07 18:09:35 +00:00
2020-08-07 18:09:35 +00:00
2020-08-07 18:09:35 +00:00
2020-07-07 06:08:20 +00:00
2020-12-08 14:53:14 +00:00
2020-11-13 07:25:36 +00:00
2020-11-13 00:29:38 +00:00
2020-12-08 14:56:04 +00:00
2020-11-21 07:36:53 +00:00
2020-12-08 10:47:43 +00:00
2020-12-08 10:47:43 +00:00
2020-12-02 14:59:13 +00:00
2020-12-02 14:59:13 +00:00
2020-08-21 21:44:50 +00:00
2020-05-30 01:06:44 +00:00
2020-11-13 22:10:54 +00:00
2020-11-13 22:10:54 +00:00
2020-11-13 22:10:54 +00:00
2020-08-26 21:32:36 +00:00
2020-06-02 13:25:01 +00:00
2020-08-26 21:32:36 +00:00
2020-11-13 22:10:54 +00:00
2020-08-26 21:32:36 +00:00
2020-12-02 18:14:18 +00:00
2020-05-15 20:28:21 +00:00
2020-05-28 17:25:58 +00:00
2020-06-25 03:36:41 +00:00
2020-08-31 12:14:38 +00:00
2020-11-10 18:41:24 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-06-25 03:36:41 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-05-20 08:14:52 +00:00
2020-12-04 22:46:12 +00:00
2020-05-26 08:47:30 +00:00
2020-11-03 10:27:44 +00:00
2020-11-03 10:27:44 +00:00
2020-05-19 17:37:10 +00:00
2020-12-09 09:39:59 +00:00
2020-12-07 19:43:48 +00:00
2020-12-01 07:27:14 +00:00
2020-12-01 07:27:14 +00:00
2020-12-04 19:38:52 +00:00
2020-12-09 09:39:59 +00:00
2020-12-08 22:14:25 +00:00
2020-06-03 17:27:41 +00:00
2020-12-08 17:41:50 +00:00
2020-06-03 17:27:41 +00:00
2020-06-03 17:27:41 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-06-10 19:57:02 +00:00
2020-09-21 19:42:42 +00:00
2020-06-25 03:36:41 +00:00
2020-06-03 17:27:41 +00:00
2020-06-03 17:27:41 +00:00
2020-11-18 22:42:31 +00:00
2020-11-18 22:42:31 +00:00
2020-11-13 19:07:20 +00:00
2020-11-11 23:42:12 +00:00
2020-11-11 23:42:12 +00:00
2020-11-11 23:42:12 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-07-17 19:29:47 +00:00
2020-12-07 19:43:48 +00:00
2020-12-02 21:08:58 +00:00
2020-12-07 20:05:38 +00:00
2020-12-08 10:47:43 +00:00
2020-10-07 22:34:24 +00:00
2020-11-23 07:51:05 +00:00
2020-06-18 11:14:13 +00:00
2020-06-17 14:01:54 +00:00
2020-11-03 10:27:44 +00:00
2020-09-08 13:16:24 +00:00
2020-10-27 23:51:57 +00:00
2020-10-16 19:22:52 +00:00
2020-10-28 17:42:35 +00:00
2020-08-12 17:23:14 +00:00
2020-08-12 17:23:14 +00:00
2020-11-27 09:11:49 +00:00
2020-11-27 09:11:49 +00:00
2020-10-28 17:42:35 +00:00
2020-12-03 02:29:38 +00:00
2020-10-28 17:42:35 +00:00
2020-12-08 13:28:24 +00:00
2020-10-28 17:42:35 +00:00
2020-12-01 07:27:14 +00:00
2020-10-02 16:17:58 +00:00
2020-11-06 19:02:23 +00:00
2020-11-13 07:25:36 +00:00
2020-08-21 21:44:50 +00:00
2020-11-03 10:27:44 +00:00
2020-11-30 18:45:02 +00:00
2020-11-03 21:39:37 +00:00
2020-12-10 15:51:27 +00:00
2020-05-27 17:04:30 +00:00
2020-12-10 15:51:27 +00:00
2020-10-28 17:42:35 +00:00
2020-12-02 21:08:58 +00:00
2020-11-17 08:51:30 +00:00
2020-12-08 10:47:43 +00:00
2020-12-08 10:47:43 +00:00
2020-06-12 11:14:22 +00:00
2020-06-12 11:14:22 +00:00
2020-06-12 11:14:22 +00:00
2020-10-28 17:42:35 +00:00
2020-06-12 11:14:22 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-12-01 07:27:14 +00:00
2020-12-01 07:27:14 +00:00
2020-11-18 22:42:31 +00:00
2020-10-22 13:08:10 +00:00
2020-11-19 08:52:41 +00:00
2020-11-19 08:52:41 +00:00
2020-09-23 19:13:29 +00:00
2020-12-03 02:29:38 +00:00
2020-11-17 08:51:30 +00:00
2020-10-28 17:42:35 +00:00
2020-10-28 17:42:35 +00:00
2020-06-12 03:29:17 +00:00
2020-06-02 13:25:01 +00:00
2020-05-15 10:57:09 +00:00
2020-05-15 10:57:09 +00:00
2020-12-08 00:36:38 +00:00
2020-12-08 00:36:38 +00:00
2020-12-08 00:36:38 +00:00
2020-12-08 00:36:38 +00:00
2020-12-08 00:36:38 +00:00
2020-12-01 07:27:14 +00:00
2020-08-04 17:19:19 +00:00
2020-08-04 17:19:19 +00:00
2020-07-02 12:01:49 +00:00
2020-06-25 03:36:41 +00:00
2020-11-13 19:07:20 +00:00
2020-12-03 12:40:28 +00:00
2020-12-03 12:40:28 +00:00
2020-10-26 19:41:46 +00:00
2020-10-26 19:41:46 +00:00
2020-10-21 19:36:56 +00:00
2020-11-19 01:05:41 +00:00
2020-09-18 12:01:11 +00:00
2020-06-29 16:10:13 +00:00
2020-12-09 09:39:59 +00:00
2020-06-02 20:40:03 +00:00
2020-05-26 10:46:05 +00:00
2020-05-26 10:46:05 +00:00
2020-08-06 19:55:12 +00:00
2020-08-06 19:55:12 +00:00
2020-11-17 17:50:08 +00:00
2020-09-15 18:32:31 +00:00
2020-12-07 19:43:48 +00:00
2020-08-07 21:40:45 +00:00
2020-08-07 21:40:45 +00:00
2020-06-25 19:51:12 +00:00
2020-06-25 19:51:12 +00:00
Vyacheslav Egorov
4b5c267dbd