Paul Berry
7e4e0326d7
This CL is part of an effort to bump the SDK requirement to `3.12.0-0` for all the packages in `pkg` that are not published to `pub`, so that we can get better testing of the "private named parameters" feature. (Packages that *are* published to `pub` can't be safely bumped yet, because SDK 3.12 hasn't been released, and I don't want to block those packages' ability to publish useful updates to customers.) This change covers the following packages, which are owned by OWNERS_WEB: - pkg/_js_interop_checks/pubspec.yaml - pkg/compiler/pubspec.yaml - pkg/dart2js_info/pubspec.yaml - pkg/dart2js_runtime_metrics/pubspec.yaml - pkg/dart2js_tools/pubspec.yaml - pkg/dev_compiler/pubspec.yaml - pkg/js_ast/pubspec.yaml - pkg/js_runtime/pubspec.yaml - pkg/js_shared/pubspec.yaml - pkg/modular_test/pubspec.yaml - pkg/node_preamble/pubspec.yaml - pkg/reload_test/pubspec.yaml - pkg/sourcemap_testing/pubspec.yaml Changes to `pubspec.yaml` files were made manually. Changes to `.dart` files were made automatically (with a few exceptions), using `dart fix` to migrate to using private named parameters where it is possible to do so without changing semantics. Note that this migration is conservative; see https://github.com/dart-lang/sdk/issues/58607 for details. The exceptions are: - pkg/compiler/test/codesize/swarm/DataSource.dart - pkg/compiler/test/codesize/swarm/Views.dart - pkg/compiler/test/codesize/swarm/swarm_ui_lib/layout/GridLayout.dart - pkg/compiler/test/codesize/swarm/swarm_ui_lib/touch/ClickBuster.dart - pkg/compiler/test/codesize/swarm/swarm_ui_lib/touch/Scrollbar.dart - pkg/compiler/test/codesize/swarm/swarm_ui_lib/touch/Scroller.dart - pkg/dev_compiler/test/sourcemap/testfiles/next_through_is_and_as_test.dart For these files, there was no need to migrate to using private named parameters, however the language version bump caused flow analysis to improve, so some additional dead code was detected that hadn't been detected previously. I reasoned that it's better to minimize changes to testcases, so rather than deleting the dead code, I just added `ignore` comments to prevent the bots from failing. Change-Id: I04f5280d7cedef0a6f0ef718133a03d06a6a6964 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487945 Auto-Submit: Paul Berry <paulberry@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
Package js_shared:
This code is a compile time dependency of dart2js and DDC. It is imported as
a package: import by both compilers.
There is an exact copy in the SDK of the libraries in the
pkg/js_shared/lib/synced sub-directory.
Those libraries are imported as dart: imports by the dart2js and DDC runtime
libraries.
Important: all code under pkg/js_shared/lib/synced must be kept in sync with
the runtime (in sdk/lib/_internal/js_shared/lib/synced) at all times. The
test/in_sync_test.dart test verifies this.