Paul Berry
5c0e0922d0
In order to address https://github.com/dart-lang/language/issues/731 (improved type inference for `fold` etc.) we're going to need to sometimes defer analysis of invocation arguments that are closures, so that closure parameters can have their types inferred based on other parameters. To avoid annoying the user with inconsistent behaviors, we defer analysis of closures in all circumstances, even if it's not necessary to do so for type inference purposes. This has a minor user-visible effect: if an invocation contains some closures and some non-closures, any demotions that happen due to write captures in the closures are postponed until the end of the invocation; this means that the write-captured variables remain promoted for other invocation arguments, even if those arguments appear after the closure. This is safe because there is no way for the closure to be called until after all of the other invocation arguments are evaluated. See the language tests in this CL for details. Note that this change only has an effect when the experimental feature `inference-update-1` is enabled. Change-Id: I283fc5eb07af2aeca0a06d523011d8c4617fbad7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237720 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency