Tess Strickland
5792b6ecb7
https://dart-review.googlesource.com/c/sdk/+/481782 removed the tracing of the original instruction for breakpoints. This CL adds it back. Also increments icount_ before calling TraceInstruction in the dispatch loop instead of afterwards so that breakpoint/single step tracing can just use icount_ without adjusting it. In particular, this means tracing the original instruction at a breakpoint can just use TraceInstruction instead of duplicating it. Also, now both the breakpoint instruction and the original instruction are written to the instruction trace if requested, instead of only the breakpoint instruction. TEST=debugging only changes, so manually tested. Cq-Include-Trybots: luci.dart.try:vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try Change-Id: I1999f1d9e7ba55b950c508e848ff12db0c8d5cab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482320 Reviewed-by: Alexander Markov <alexmarkov@google.com> Auto-Submit: Tess Strickland <sstrickl@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>