Paul Berry
1c86b2f5f6
Prior to this fix, if the user's package had a relative import from outside `lib` to inside `lib` (e.g. from `test` to `lib`), the migration tool would regard the imported file as being reached via a `file:` URI. This caused it to get confused and complain that the user had a dependency on unmigrated code (this happened because the check for dependency on unmigrated code excluded the user's files via their canonical URIs, and files inside `lib` use `package:` for their canonical URIs). To fix the problem, we modify the check for dependency on unmigrated code so that it excludes the user's files via their path rather than their URI. Note that relative imports into the `lib` directory are discouraged by the style guide*, but it still seems worth fixing this bug since they do crop up in the wild. *https://dart.dev/guides/language/effective-dart/usage#dont-allow-an-import-path-to-reach-into-or-out-of-lib Fixes #45780. Bug: https://github.com/dart-lang/sdk/issues/45780 Change-Id: Iff41ca0059d78bbb812dd6f421be6458e7049895 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196344 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency