Daco Harkes
532c116cd2
This CL implements `NativeFinalizer` in the GC. `FinalizerEntry`s are extended to track `external_size` and in which `Heap::Space` the finalizable value is. On attaching a native finalizer, the external size is added to the relevant heap. When the finalizable value is promoted from new to old space, the external size is promoted as well. And when a native finalizer is run or is detached, the external size is removed from the relevant heap again. In contrast to Dart `Finalizer`s, `NativeFinalizer`s are run on isolate shutdown. When the `NativeFinalizer`s themselves are collected, the finalizers are not run. Users should stick the native finalizer in a global variable to ensure finalization. We will revisit this design when we add send and exit support, because there is a design space to explore what to do in that case. This current solution promises the least to users. In this implementation native finalizers have a Dart entry to clean up the entries from the `all_entries` field of the finalizer. We should consider using another data structure that avoids the need for this Dart entry. See the TODO left in the code. Bug: https://github.com/dart-lang/sdk/issues/47777 TEST=runtime/tests/vm/dart(_2)/isolates/fast_object_copy_test.dart TEST=runtime/vm/object_test.cc TEST=tests/ffi(_2)/vmspecific_native_finalizer_* Change-Id: I8f594c80c3c344ad83e1f2de10de028eb8456121 Cq-Include-Trybots: luci.dart.try:vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-ffi-android-debug-arm64c-try,dart-sdk-mac-arm64-try,vm-kernel-mac-release-arm64-try,pkg-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try,vm-kernel-win-debug-x64c-try,vm-kernel-win-debug-x64-try,vm-kernel-precomp-win-debug-x64c-try,vm-kernel-nnbd-win-release-ia32-try,vm-ffi-android-debug-arm-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-mac-debug-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,benchmark-linux-try,flutter-frontend-try,pkg-linux-debug-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-gcc-linux-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236320 Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
57 lines
2.7 KiB
Plaintext
57 lines
2.7 KiB
Plaintext
# Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
|
|
function_callbacks_structs_by_value_test: Pass, Slow # https://dartbug.com/47304 https://dartbug.com/45007
|
|
function_structs_by_value_generated_test: Pass, Slow # https://dartbug.com/47303 https://dartbug.com/45007
|
|
|
|
[ $builder_tag == msan ]
|
|
vmspecific_handle_test: Skip # https://dartbug.com/42314
|
|
|
|
[ $compiler == app_jitk ]
|
|
vmspecific_leaf_call_test: Skip # https://dartbug.com/46125: Snapshot fails to generate.
|
|
|
|
[ $mode == debug ]
|
|
function_callbacks_structs_by_value_generated_test: Pass, Slow
|
|
|
|
[ $mode == product ]
|
|
regress_47594_test: Skip # Profiler is not available in Product.
|
|
|
|
[ $system == android ]
|
|
*: Pass, Slow # https://github.com/dart-lang/sdk/issues/38489
|
|
regress_47594_test: Skip # DartDev is not available on Android.
|
|
vmspecific_native_finalizer_isolate_groups_test: Skip # SpawnUri not available on Android tester.
|
|
|
|
[ $system == windows ]
|
|
regress_47594_test: Skip # DynamicLibrary.process() is not available on Windows.
|
|
|
|
[ $compiler != dart2analyzer && $compiler != fasta && $runtime != dart_precompiled && $runtime != vm ]
|
|
*: SkipByDesign # FFI is a VM-only feature. (This test suite is part of the default set.)
|
|
|
|
[ $compiler == dartkp && $system == windows ]
|
|
vmspecific_handle_test: SkipByDesign # Symbols are not exposed on purpose and are not linked in Windows Precompiled. dartbug.com/40579
|
|
|
|
[ $system != android && $system != linux && $system != macos && $system != windows ]
|
|
*: Skip # FFI not yet supported on other OSes.
|
|
|
|
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simriscv32 || $arch == simriscv64 ]
|
|
*: Skip # FFI not yet supported on the arm simulator.
|
|
|
|
[ $builder_tag == asan || $builder_tag == msan || $builder_tag == tsan ]
|
|
data_not_asan_test: SkipByDesign # This test tries to allocate too much memory on purpose.
|
|
|
|
# These tests trigger and catch an abort (intentionally) and terminate the VM.
|
|
# They're incompatible with ASAN because not all memory is freed when aborting and
|
|
# with AppJit because the abort the VM before it can generate a snapshot.
|
|
[ $builder_tag == asan || $compiler == app_jitk ]
|
|
vmspecific_function_callbacks_exit_test: SkipByDesign
|
|
|
|
[ $compiler == dart2analyzer || $compiler == fasta ]
|
|
vmspecific_enable_ffi_test: SkipByDesign # This is a check for VM only.
|
|
|
|
[ $compiler == dartkp || $arch == arm64 && $system == fuchsia ]
|
|
abi_specific_int_incomplete_jit_test: SkipByDesign # Only intended to run in JIT mode.
|
|
|
|
[ $compiler != dartkp || $arch == arm64 && $system == fuchsia ]
|
|
abi_specific_int_incomplete_aot_test: SkipByDesign # Only intended to run in AOT mode.
|