Martin Kustermann
933d8e913f
Hitting the assertion from the issue (see below) is innocent: It informs us that we should avoid speculating operands to be Smis if we actually know for sure the receiver cannot be a Smi (based on interface target). This particular case was hit on an instance call `a ^ b` where the interface type tells us it is `boo.^` - so we shouldn't insert CheckedSmiOp. There might be more cases where we insert CheckedSmiOp/CheckedSmiComparison instructions where we shouldn't (because interface target tells us receiver cannot be a Smi). -> In debug mode we'll hit this assertion, so if the fuzzer finds more such cases, we should fix them one-by-one. Fixes https://github.com/dart-lang/sdk/issues/40937 Change-Id: I55624f77b9edeece4d1334f1629ce5514cf3784a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139812 Reviewed-by: Ben Konyi <bkonyi@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Dart VM Compilation Pipeline
This folder contains Dart VM compilation pipeline.
Compilation pipeline is mainly responsible for converting AST or Kernel AST into IL flow graphs and then generating native code from IL.
It has the following structure:
| Directory | What goes there |
|---|---|
assembler/ |
Assemblers and disassemblers |
backend/ |
IL based compilation backend: optimization passes and architecture specific code generation rules |
frontend/ |
Frontends responsible for converting AST into IL |
jit/ |
JIT specific passes and compilation pipeline entry points |
aot/ |
AOT specific passes and compilation pipeline entry points |
. |
Shared code or code without clear designation. |
Currently there are no layering restrictions and components from different subfolders can reference each other.