Konstantin Shcheglov
5273f91b95
Remove the analyzer-only `scanner/reader.dart` re-export and refactor `Scanner` to accept source text directly. * Delete `pkg/analyzer/src/dart/scanner/reader.dart`, which only re-exported `_fe_analyzer_shared` reader types. * Replace the `Scanner(CharacterReader, ...)` factory with `Scanner(String contents, ...)`, aligning the API with the underlying `scanString` implementation. * Update analyzer, analysis_server, analyzer_cli, analyzer_plugin, and scrape call sites to pass the source string directly instead of constructing `CharSequenceReader`. This removes an unnecessary abstraction layer, reduces imports/indirection, and makes scanner usage simpler and more uniform across the repo. Change-Id: I380b365676c8a62971a3700deadb695d1519d653 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/477600 Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
SDK development code analysis
dartanalyzer used to be the tool for statically analyzing dart code
at the command line. However, this tool has been replaced with
dart analyze for this purpose in current SDKs and will no longer
be published on pub.
Do not depend on the command line interface or other semantics in
this directory as it is now an internal tool for SDK development, used
as the dart2analyzer "compiler" for tools/test.py in the SDK.
It is configured as part of the test runner,
here.
SDK development usage
For SDK development, run analysis from the test tool to validate analysis conclusions on language samples in the testing directory. From the root of the SDK:
tools/test.py --build --use-sdk -c dart2analyzer co19 language
This will build the Dart VM and compile dartanalyzer into a snapshot, then use
that snapshot while analyzing those directories under testing/. Without
--use-sdk, test.py will use the source code version of the analyzer
instead of the compiled one, which can be useful for debugging.