903d77cc82
Work towards https://github.com/dart-lang/sdk/issues/60635 I tried to keep this minimal but still sensible: * Rename AnalysisErrorListener and all subtypes to use 'Diagnostic'. * Rename all instantiations of such classes if they previously contained the word 'error'. * Rename `RecordingDiagnosticListener.errors` to `.diagnostics`. * Rename some _testing_ instance members that had the word 'error' to instead use 'diagnostic'. Change-Id: I3948e27ba28ac2494092e04f4e1d201a20cc1135 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433004 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>