Lasse Reichstein Holst Nielsen
f0172a4c41
This allows `async` and `async*` functions to be typed without importing `dart:async`. All other async types still need to be imported, including `FutureOr` and `Zone`, but pure `async`/`await` based code can be written with no imports. Fixes #26162. Bug: http://dartbug.com/26162 Change-Id: Iaf36631ef5b3251a688e495a9d238b2f8787f14c Reviewed-on: https://dart-review.googlesource.com/71480 Reviewed-by: Leaf Petersen <leafp@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
62 lines
1.8 KiB
Dart
62 lines
1.8 KiB
Dart
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:analysis_server/protocol/protocol_generated.dart';
|
|
import 'package:analyzer_plugin/protocol/protocol_common.dart';
|
|
import 'package:test/test.dart';
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import '../support/integration_tests.dart';
|
|
|
|
main() {
|
|
defineReflectiveSuite(() {
|
|
defineReflectiveTests(GetFixesTest);
|
|
});
|
|
}
|
|
|
|
@reflectiveTest
|
|
class GetFixesTest extends AbstractAnalysisServerIntegrationTest {
|
|
test_has_fixes() async {
|
|
String pathname = sourcePath('test.dart');
|
|
String text = r'''
|
|
FutureOr f;
|
|
''';
|
|
writeFile(pathname, text);
|
|
standardAnalysisSetup();
|
|
|
|
await analysisFinished;
|
|
expect(currentAnalysisErrors[pathname], isNotEmpty);
|
|
|
|
EditGetFixesResult result =
|
|
await sendEditGetFixes(pathname, text.indexOf('FutureOr f'));
|
|
|
|
expect(result.fixes, hasLength(1));
|
|
AnalysisErrorFixes fix = result.fixes.first;
|
|
expect(fix.error.code, 'undefined_class');
|
|
|
|
// expect a suggestion to add the dart:async import
|
|
expect(fix.fixes, isNotEmpty);
|
|
|
|
SourceChange change = fix.fixes.singleWhere(
|
|
(SourceChange change) => change.message.startsWith('Import '));
|
|
expect(change.edits, hasLength(1));
|
|
expect(change.edits.first.edits, hasLength(1));
|
|
}
|
|
|
|
test_no_fixes() async {
|
|
String pathname = sourcePath('test.dart');
|
|
String text = r'''
|
|
import 'dart:async';
|
|
|
|
FutureOr f;
|
|
''';
|
|
writeFile(pathname, text);
|
|
standardAnalysisSetup();
|
|
|
|
EditGetFixesResult result =
|
|
await sendEditGetFixes(pathname, text.indexOf('FutureOr f'));
|
|
expect(result.fixes, isEmpty);
|
|
}
|
|
}
|