Johnni Winther
4cfd3da965
This update the position used for reporting a mixin class primary constructor with a primary constructor by declaration with initializers or an explicit body. Since mixin classes can have simple constructors, it makes more sense to report the error on the offending syntax than on the primary constructor itself. The CL also updates the offset used for field initializers to the field name rather than the `=`. This align the offset with what is used for property sets. Change-Id: Id5ccd55536b2c3b9d9336d2854772c1bcc5a175a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490800 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
25 lines
910 B
Dart
25 lines
910 B
Dart
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
class Foo {
|
|
Foo(this.x);
|
|
// ^
|
|
// [analyzer] COMPILE_TIME_ERROR.FINAL_INITIALIZED_IN_DECLARATION_AND_CONSTRUCTOR
|
|
// [cfe] 'x' is a final instance variable that was initialized at the declaration.
|
|
final int x = 42;
|
|
}
|
|
|
|
class CoffeeShop {
|
|
final String shopName = "Coffee Lab";
|
|
CoffeeShop.name(String shopName) : this.shopName = shopName;
|
|
// ^^^^^^^^
|
|
// [analyzer] COMPILE_TIME_ERROR.FIELD_INITIALIZED_IN_INITIALIZER_AND_DECLARATION
|
|
// [cfe] 'shopName' is a final instance variable that was initialized at the declaration.
|
|
}
|
|
|
|
void main() {
|
|
Foo f = new Foo(10);
|
|
CoffeeShop presidentialCoffee = new CoffeeShop.name("Covfefe Lab");
|
|
}
|