Sam Rawlins
f397ecb588
This involves changes of a few flavors: * Make classes private which were unnecessarily public. * Make class elements private which were unnecessarily public. * Comment in places where a "public" API contains a private type, but this is because of the signature of a super-member. I think these are generally quite safe. Change-Id: Ied1864202cc256205a3b421ddec5513f0a22a608 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243647 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Analysis Server Benchmarks
How to run the benchmarks
To see a list of all available benchmarks, run:
dart benchmark/benchmarks.dart list
To run an individual benchmark, run:
dart benchmark/benchmarks.dart run <benchmark-id>
How they're tested
In order to make sure that our benchmarks don't regress in terms of their ability to run, we create one unit test per benchmark, and run those tests as part of our normal CI test suite.
To save time on the CI, we only run one iteration of each benchmark
(--repeat=1), and we run the benchmark on a smaller data set (--quick).
See test/benchmark_test.dart.
To add a new benchmark
Register the new benchmark in the main() method of benchmark/benchmarks.dart.
On the bots
Our benchmarks run on a continuous performance testing system. Currently, the benchmarks need to be manually registered ahead of time.