Files
sdk/tests/language_2/stack_trace/stack_trace_test.dart
T
Tess Strickland 3b9b77964d Reland "[vm/compiler] Move AssertAssignables out of closure bodies."
This is a reland of 42c76fd910

Main issue was due to the parameter order of the invoke field dispatcher
not matching the argument order described by its saved arguments
descriptor. There's no reason for it not to, so now it does.

Also fixes some issues with stack trace tests that failed due to
increased deduplication of closures by forbidding deduplication for
those tests.

TEST=Run on trybots of all architectures as well as flutter engine
trybot, new test added for downstream issues seen after initial landing.

Original change's description:
> [vm/compiler] Move AssertAssignables out of closure bodies.
>
> This CL moves the final set of checks out of closure bodies and into
> dynamic closure call dispatchers.  It also adds stubs for checking top
> types and null assignability for types only known at runtime.
>
> Fixes https://github.com/dart-lang/sdk/issues/40813 .
>
> Changes in Flutter gallery in release mode:
>
> * arm7: -3.05% total, +0.99% vmisolate, -0.89% isolate,
>         -1.20% readonly, -4.43% instructions
> * arm8: -3.20% total, +0.99% vmisolate, -0.88% isolate,
>         -1.18% readonly, -5.05% instructions
>
> TEST=Run on trybots of all architectures, includes test adjustments where needed.
>
> Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try
> Change-Id: Ifb136c64339be76a642ecbb4fda26b6ce8f871f9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166622
> Commit-Queue: Tess Strickland <sstrickl@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

Change-Id: Ic5ec59cf355f7779bb82db798d97d762ba1e5556
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-linux-product-x64-try,flutter-engine-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172644
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2020-11-18 22:42:31 +00:00

140 lines
2.6 KiB
Dart

// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// Dart test program for testing throw statement
import "package:expect/expect.dart";
class MyException {
const MyException(String message) : message_ = message;
final String message_;
}
class Helper {
static int f1(int i) {
try {
i = func();
i = 10;
} on MyException catch (exception, stacktrace) {
i = 50;
print(exception.message_);
Expect.isNotNull(stacktrace);
print(stacktrace);
}
try {
int j;
i = func1();
i = 200;
} on MyException catch (exception, stacktrace) {
i = 50;
print(exception.message_);
Expect.isNotNull(stacktrace);
print(stacktrace);
}
try {
int j;
i = func2();
i = 200;
} on MyException catch (exception, stacktrace) {
i = 50;
print(exception.message_);
Expect.isNotNull(stacktrace);
print(stacktrace);
} finally {
i = i + 800;
}
return i;
}
static int func() {
int i = 0;
while (i < 10) {
i++;
}
if (i > 0) {
throw new MyException("Exception Test for stack trace being printed");
}
return 10;
}
static int func1() {
try {
func();
} on MyException catch (exception) {
throw new MyException("Exception Test for stack trace being printed");
;
}
return 10;
}
static int func2() {
try {
func();
} on MyException catch (exception) {
rethrow;
}
return 10;
}
}
class StackTraceTest {
static testMain() {
Expect.equals(850, Helper.f1(1));
}
}
// Test that the full stack trace is generated for rethrow.
class RethrowStacktraceTest {
var config = 0;
@pragma("vm:entry-point") // Prevent obfuscation
@pragma("vm:never-inline") // Prevent inlining
issue12940() {
throw "Progy";
}
b() {
issue12940();
}
c() {
if (config == 0) {
try {
b();
} catch (e) {
rethrow;
}
} else {
try {
b();
} catch (e, s) {
rethrow;
}
}
}
d() {
c();
}
testBoth() {
for (config = 0; config < 2; config++) {
try {
d();
} catch (e, s) {
Expect.contains("issue12940", s.toString());
}
}
}
static testMain() {
var test = new RethrowStacktraceTest();
test.testBoth();
}
}
main() {
StackTraceTest.testMain();
RethrowStacktraceTest.testMain();
}