Liam Appelbe
4679c040c6
Adds a new code path for NativeCallable.isolateLocal invocations. If the current thread is not entered into any isolate, but owns the target isolate, then it enters the target isolate, invokes, then exits the isolate. Fixes: https://github.com/dart-lang/sdk/issues/61623 TEST=tests/ffi/function_callbacks_isolate_ownership_test.dart Change-Id: I401f185fadf7d2a55190dafd15387e1c418c67c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/452380 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Liam Appelbe <liama@google.com>
47 lines
2.0 KiB
C++
47 lines
2.0 KiB
C++
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/bss_relocs.h"
|
|
#include "vm/native_symbol.h"
|
|
#include "vm/runtime_entry.h"
|
|
#include "vm/thread.h"
|
|
|
|
namespace dart {
|
|
|
|
void BSS::InitializeBSSEntry(BSS::Relocation relocation,
|
|
uword new_value,
|
|
uword* bss_start) {
|
|
std::atomic<uword>* slot = reinterpret_cast<std::atomic<uword>*>(
|
|
&bss_start[BSS::RelocationIndex(relocation)]);
|
|
uword old_value = slot->load(std::memory_order_relaxed);
|
|
// FullSnapshotReader::ReadProgramSnapshot, and thus BSS::Initialize, can
|
|
// get called multiple times for the same isolate in different threads, though
|
|
// the initialized value will be consistent and thus change only once. Avoid
|
|
// calling compare_exchange_strong unless we actually need to change the
|
|
// value, to avoid spurious read/write races by TSAN.
|
|
if (old_value == new_value) return;
|
|
if (!slot->compare_exchange_strong(old_value, new_value,
|
|
std::memory_order_relaxed)) {
|
|
RELEASE_ASSERT(old_value == new_value);
|
|
}
|
|
}
|
|
|
|
void BSS::Initialize(Thread* current, uword* bss_start, bool vm) {
|
|
// TODO(https://dartbug.com/52579): Remove.
|
|
InitializeBSSEntry(Relocation::DLRT_GetFfiCallbackMetadata,
|
|
reinterpret_cast<uword>(DLRT_GetFfiCallbackMetadata),
|
|
bss_start);
|
|
InitializeBSSEntry(Relocation::DLRT_ExitTemporaryIsolate,
|
|
reinterpret_cast<uword>(DLRT_ExitTemporaryIsolate),
|
|
bss_start);
|
|
InitializeBSSEntry(Relocation::DLRT_ExitIsolateGroupBoundIsolate,
|
|
reinterpret_cast<uword>(DLRT_ExitIsolateGroupBoundIsolate),
|
|
bss_start);
|
|
InitializeBSSEntry(
|
|
Relocation::DLRT_ExitSyncCallbackTargetIsolate,
|
|
reinterpret_cast<uword>(DLRT_ExitSyncCallbackTargetIsolate), bss_start);
|
|
}
|
|
|
|
} // namespace dart
|